1694659 - Update permit unload / beforeunload / unload warning prompt wording

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[:Gijs (he/him)]

This would involve updating the strings at https://searchfox.org/mozilla-central/rev/a23e65c5d69a821f61d14c8ec1f69a120e3f77d1/browser/components/prompts/PromptCollection.jsm#80-94

The buttons should use sentence case (so "Leave page" and "Stay on page").

The message should be

"This page is asking you to confirm that you want to leave — information you’ve entered may not be saved."

Edit: fixed spacing per Meridel's answer in comment #1.

Meridel, this is copied from figma (using the copy button there...), where there is a newline after the em-dash and no other spacing. We can't guarantee how things wrap because we don't control the font size - can you clarify what you want us to do for spacing around the em-dash?

Comment 1

[Meridel [:meridel]]

Thanks, Gijs. There should be a space on either side of em dash. I will update the Figma file.

Comment 2

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1694659 - Update permit unload / beforeunload / unload warning prompt wording, r=Gijs.

Comment 4

[Florian Quèze [:florian]]

I see in the figma spec that the "Are you sure?" title should be replaced with the hostname. Is it correct to assume that this will be handled in bug 1693008?

Comment 5

[:Gijs (he/him)]

(In reply to Florian Quèze [:florian] from comment #4)

I see in the figma spec that the "Are you sure?" title should be replaced with the hostname. Is it correct to assume that this will be handled in bug 1693008?

Yes, there or another bug. It's a bit complicated because the title is passed by native code and we want a different title dependent on a pref. It doesn't need to be solved here.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0661fa0248
Update permit unload / beforeunload / unload warning prompt wording, r=Gijs.

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f0661fa0248

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81dee14347bd
Port bug 1694659 - Update permit unload / beforeunload / unload warning prompt wording. rs=bustage-fix

Comment 9

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit)

• The buttons are using sentence case ( "Leave page" and "Stay on page").
• The message reads "This page is asking you to confirm that you want to leave — information you’ve entered may not be saved."
  Updating status accordingly.
  Best regards,
  Clara