Closed
Bug 1694680
Opened 3 years ago
Closed 3 years ago
Fix qcms_data_create_rgb_with_gamma.
Categories
(Core :: Graphics: Color Management, defect)
Core
Graphics: Color Management
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
This fixes a number of problems:
-
The check around get_rgb_colorants was inverted. This caused us to
only continue if the colorants were wrong. -
get_rgb_colorants can just return the Matrix instead of taking
a reference to it. -
The OOBs checks in write_u32 and write_u16 had their conditions
inverted. -
No tests
|
Assignee | |
Comment 1•3 years ago
|
||
This fixes a number of problems:
-
The check around get_rgb_colorants was inverted. This caused us to
only continue if the colorants were wrong. -
get_rgb_colorants can just return the Matrix instead of taking
a reference to it. -
No tests
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa296c490720 Fix qcms_data_create_rgb_with_gamma.
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•