1694721 - SW-WR crashes if you enable some of the gfx.webrender.debug prefs

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mayank Bansal]

STR1

1. Enable sw-wr
2. Open a couple of tabs
3. set gfx.webrender.debug.obscure-images to true
   4 Switch tabs, or scroll a long page

AR: Crash

STR2:

1. Enable sw-wr
   1.5Open about:config
2. set gfx.webrender.debug.primitives to true
3. Toggle it back to false

AR: Crash

STR3 :

1. Enable sw-wr
2. Open a couple of tabs
3. set gfx.webrender.debug.capture-profiler to true
   4 Switch tabs, or scroll a long page

STR4:

1. Enable sw-wr
   1.5Open about:config
2. set gfx.webrender.debug.picture-caching to true
3. Toggle it back to false

Comment 1

[Mayank Bansal]

for gfx.webrender.debug.obscure-images : https://crash-stats.mozilla.org/report/index/d40d6c08-8bf0-4a60-a167-a01f60210224

for the other pref, https://crash-stats.mozilla.org/report/index/c00d0d83-5912-4f50-b7fa-ba3420210224

Comment 2

[Mayank Bansal]

Attachment: about:support

Comment 3

[Jim Blandy :jimb]

On Linux SW-WR, some of these features are clearly broken, but none of the STR in comment 0 cause a crash.

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1694721 - Check for valid FB before drawing in SWGL. r?jrmuizel

There are some theoretical cases where the FB state might get a bit tortured
and we might encounter some invalid FB state while drawing. This adds some
extra validation just to be safe.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dc5d2aa5b68
Check for valid FB before drawing in SWGL. r=jrmuizel

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6dc5d2aa5b68

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Managed to reproduce all crashes by following comment 0 str with Firefox 88.0a1 (2021-02-24) on mac M1 mini 11.2.3. The only thing that I did differently was restarting Firefox after setting sw-wr to true and following the next steps.

Unfortunately with Firefox 88.0b8 (20210406185740) on the same machine, I can still reproduce the crashes following STR 2,3,4 from comment 0. STR1 doesn't crash for me but while having gfx.webrender.debug.obscure-images:true and sw-wr displays some weird glitches on the browser and webpages. I don't know if this is expected tho.
Should we reopen this bug?

Comment 8

[Lee Salzman [:lsalzman]]

Attachment: Bug 1694721 - Don't do a debug render if there is no debug overlay. r?gw

When toggling debug state, we can sometimes queue debug renders, without
any debug overlay to send them to. This patch ensures we don't actually
draw anything in the debug renderer when there is no debug overlay.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60a6ecfe134
Don't do a debug render if there is no debug overlay. r=gw

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d60a6ecfe134

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 89.0a1 (20210411210108) on Windows 10x64, macOS 11.2.3M1 mini and Ubuntu 20.04. No crashes occur when following the STR from comment 0. Removing the qe+ flag.