WebRender Sequence Capture doesn't get turned off in render backend
Categories
(Core :: Graphics: WebRender, defect, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
The wr_api_stop_capture_sequence function is supposed to tell WebRender to stop logging data requested by a prior call to wr_api_start_capture_sequence, but the change is not propagated correctly to the render backend thread, which continues writing data to the capture directory. In fact, if sequence capture is enabled a second time, the render backend panics because the scene id number appears to have gone backwards.
|
Assignee | |
Comment 1•3 years ago
|
||
The RenderBackend::capture_config field determines whether the render backend
logs ongoing activity as requested by wr_api_start_capture_sequence. This
field is set by SceneBuilderResult::CapturedTransactions messages, but there
is nothing that clears it. This patch adds an additional SceneBuilderResult
message to do so.
It would probably suffice to simply always clear capture_config upon receipt
of an ordinary Transactions message. But it seemed to me to be slighty nicer
to leave capture control to messages specific to that purpose, rather than
letting ordinary messages affect it implicitly.
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6618664682a Let the WebRender render backend know when sequence capture should stop. r=nical
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•