1694763 - [wpt-sync] Sync PR 27765 - Fix NG table collapsed border pixel-snapping and clipping

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27765 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27765
Details from upstream follow.

b'Xianzhu Wang <[e-mail]>' wrote:

Fix NG table collapsed border pixel-snapping and clipping

This fixes the following issues:

• We missed pixel-snapping of the collapsed borders.
  Add ObjectPainterBase::DrawBoxSide() which accepts IntRect instead of
  float parameters. Previously if the float parameters were not
  pixel-snapped, they would be converted to int by truncating which
  implicitly snapped to whole pixels incorrectly.

• We missed pixel-snapping and shrinking by border outsets for the clip
  when painting background for layered table parts. Combine the clip
  logic for cell background and other table part background with
  correct pixel-snapping and clip rect, with a test.

Bug: 1180773
Change-Id: I81a967b3de08c116eed97a08e0f608a966088f40

Reviewed-on: https://chromium-review.googlesource.com/2717524
WPT-Export-Revision: dcc5d7946909547be5da9c6a29cdd732f6f0d272

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4be31c6c4ea22a599ba5e6dea08e4d6e7684afe3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-tables/collapsed-border-positioned-tr-td.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b6f898a24f2
[wpt PR 27765] - Fix NG table collapsed border pixel-snapping and clipping, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f71b1b1a662d
[wpt PR 27765] - Update wpt metadata, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8b6f898a24f2
https://hg.mozilla.org/mozilla-central/rev/f71b1b1a662d