1694772 - Improve windows developer experience for npm run debugcoverage

Status: NEW

(Firefox :: Messaging System, task, P3)

Description

[Ed Lee :Mardak]

barret has run into some issues with running unit tests on windows but seems to have gotten it mostly working.

FIREFOX_BIN needed to be set for testmc:unit as command arg in karma config doesn't work.

The debugcoverage script uses open but doesn't exist for windows/mozilla-build, but the log files do exist and can be manually opened.

Comment 1

[Emily McMinn :emcminn]

Barret, would you mind trying a few things? I'm trying to figure out how specific the issues are (debugcoverage is definitely a problem).

First, from the mozilla-central directory, can you run unit tests with ./mach npm run test --prefix=browser/components/newtab ? If it fails, does it fail at the linting step or after that?

If linting fails with the above, do the tests run if you do ./mach npm run testmc:unit --prefix=browser/components/newtab ?

Last, what happens when you run ./mach npm run tddmc --prefix=browser/components/newtab ? Does webpack start watching/the karma window open ok?

Thanks!

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: test.log

here is the result of `mach npm run test --prefix=browser/components/newtab`. Running `npm test` in `browser/components/newtab` has the same result:

Comment 3

[Barret Rennie [:barret] (they/them)]

Both ./mach npm run testmc:unit --prefix=browser/components/newtab and cd browser/components/newtab; npm run testmc:unit work as expected (Firefox is launched headlessly and tests run and pass)

Both ./mach npm run tddmc --prefix/browser/components/newtab and cd browser/components/newtab; npm run tddmc work as expected (Firefox is launched normally and tests run and pass). webpack correctly watches for changes and rebuilds, which re-runs the tests.

Comment 4

[Emily McMinn :emcminn]

Given that there may be some changes coming soon from the Windows build team, I'm going to de-prioritize this and we can revisit once changes have been made.

Comment 5

[Ed Lee :Mardak]

Bug 1737419 updates the source docs notes giving examples of how to run testmc:unit and bug 1736617 sets FIREFOX_BIN. Bug 1698208 covers fixing lint so test works, so the only thing here might just be debugcoverage usage of open?