1694777 - Update audioipc to 8fb5ff19

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task, P3)

Description

[Matthew Gregan [:kinetik]]

This includes:

a5fd9ee - server: Drop unused SharedMem after RPC setup.
4d405d0 - Use VM-backed anonymous shmem regions on Windows (#115)
fa262b5 - server: Clean up ServerStream if stream_init fails.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 1694777 - Update audioipc to 8fb5ff19. r?#cubeb-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98ce934ae615
Update audioipc to a5fd9eef.  r=cubeb-reviewers,chunmin

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing multiple crashed in RustMozCrash

Backout link: https://hg.mozilla.org/integration/autoland/rev/e195d65809ee12ee295bbd1cbd8a202b8ed49128

Push with failures

Failure log mochitest

Failure log reftest

Failure log wpt

Comment 4

[Matthew Gregan [:kinetik]]

Missing cast caused issues in 32-bit builds - trivial fix: https://github.com/mozilla/audioipc-2/commit/8fb5ff19fba7b09e8e66598122421e68a5c573ac

Comment 5

[Matthew Gregan [:kinetik]]

.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b7cd2cab245
Update audioipc to 8fb5ff19.  r=cubeb-reviewers,chunmin

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5b7cd2cab245

Comment 8

[Matthew Gregan [:kinetik]]

Comment on attachment 9205204 [details]
Bug 1694777 - Update audioipc to 8fb5ff19. r?#cubeb-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Many shared memory IPC setup temp files are leaked if media playback is active on systems with no audio devices (bug 1679500, since Firefox 84)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Change includes a significant rewrite of the shared memory module of audioipc (affecting Windows only)
• String changes made/needed: none

Comment 9

[Julien Cristau [:jcristau]]

(In reply to Matthew Gregan [:kinetik] from comment #8)

• Why is the change risky/not risky? (and alternatives if risky): Change includes a significant rewrite of the shared memory module of audioipc (affecting Windows only)

If this ends up causing issues how likely are we to notice and fix within a week or so?

Comment 10

[Matthew Gregan [:kinetik]]

(In reply to Julien Cristau [:jcristau] from comment #9)

(In reply to Matthew Gregan [:kinetik] from comment #8)

• Why is the change risky/not risky? (and alternatives if risky): Change includes a significant rewrite of the shared memory module of audioipc (affecting Windows only)

If this ends up causing issues how likely are we to notice and fix within a week or so?

Fair likely, I think. The entire API of the module is exercised during regular audio playback/capture, so fairly well covered in testing also.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9205204 [details]
Bug 1694777 - Update audioipc to 8fb5ff19. r?#cubeb-reviewers

approved for 87.0b6, thanks

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b0c254ff3c3f