1694849 - Remove or update probes expiring in Firefox 89: devtools.accessibility.tabbing_order_activated

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, task)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 89 [1].

devtools.accessibility.tabbing_order_activated

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This will let the test devtools/client/accessibility/test/browser/browser_tabbing_order_telemetry.js fail when the Gecko version number gets increased to 89 on 2021-03-22. Please extend the probe or remove it before that date.

Comment 2

[James Teh [:Jamie]]

Asa, do we still want telemetry concerning when the tabbing order tool in the Dev Tools A11y Panel is activated? On one hand, it's useful to have the data so we know whether it's getting usage. On the other hand, we don't have anyone staffed to work on it anyway, which may make it hard to justify extending the probe to the data stewards.

Comment 3

[Asa Dotzler [:asa]]

(In reply to James Teh [:Jamie] from comment #2)

Asa, do we still want telemetry concerning when the tabbing order tool in the Dev Tools A11y Panel is activated?

I don't think we'll be actively monitoring this because, as you said, there's no one working in this area right now. I think we can let it expire and if we pick up the investment in dev tools in the future, we can always add it back if it seems needed then.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Given the fix needs to have landed before the central-to-beta merge next Monday, what is the plan here: Test removal or test disabling?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1694849 - disable devtools a11y's browser_tabbing_order_telemetry.js because its probe expires with switch to Firefox 89. DONTBUILD

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/7bff3dc37b07
disable devtools a11y's browser_tabbing_order_telemetry.js because its probe expires with switch to Firefox 89. a=test-disabling

Comment 7

[James Teh [:Jamie]]

Morgan, might you have cycles to deal with this? We need to:

1. Remove the test;
2. Update the Dev Tools A11y Panel code to remove the telemetry submission for this probe; and
3. Remove the probe from Scalars.yaml.

Comment 8

[Morgan Reschenberg [:morgan]]

Yep I'll take this :) thanks for the flag

Comment 9

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1694849: Remove devtools.accessibility.tabbing_order_activated probe and associated test r?Jamie

Comment 10

[Intermittent Failures Robot]

12 failures in 3967 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 12

Platform and build breakdown:

• linux1804-64: 2
  • debug: 2
• windows10-64: 2
  • debug: 1
  • asan: 1
• macosx1014-64-qr: 1
  • debug: 1
• linux1804-64-asan: 1
  • opt: 1
• linux1804-64-ccov: 1
  • opt: 1
• linux1804-64-shippable: 3
  • opt: 3
• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694849&startday=2021-03-22&endday=2021-03-28&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41dac4a019c3
Remove devtools.accessibility.tabbing_order_activated probe and associated test r=Jamie

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/41dac4a019c3