Remove or update probes expiring in Firefox 89: telemetry.environment_didnt_change
Categories
(Toolkit :: Telemetry, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: telemetry-probes, Assigned: chutten)
References
Details
(Whiteboard: [probe-expiry-alert])
Attachments
(1 file)
The following Firefox probes will expire in the next major Firefox nightly release: version 89 [1].
telemetry.environment_didnt_change
What to do about this:
- If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
- If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].
If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.
Your Friendly, Neighborhood Telemetry Team
[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md
This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.
|
Assignee | |
Comment 1•3 years ago
|
||
Happy to remove it. (Though first I should probably finish my analysis on it)
|
|
Assignee | |
Comment 2•3 years ago
|
||
From https://sql.telemetry.mozilla.org/queries/78241/source#194558, the proportion of "main" pings we receive on release that have observed at least one environment-change notification that ended up not actually containing a change to the environment is well under 1% (noisily hanging out around 0.4% or about 4k per million pings). That puts an upper bound on the proportion of pings we'd suppress by not sending pings for these changes that didn't change anything.
I propose we stop sending "environment-change" notifications (and thus "environment-change"-reason "main" pings) if the environment didn't actually change. Saving us and our users storage and bandwidth and CPU.
:tdsmith, you helped me with the original bug. What do you think?
|
|
Assignee | |
Comment 3•3 years ago
|
||
Opinions from within the team that I polled at today's meeting is that I should go ahead and suppress these changes. I'll move forward with the engineering for that while I await Tim's answer.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c2648d3a758 Suppress environment changes that didn't. r=TravisLong
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•