1694886 - Extract DevTools test helper getTargetForTab(tab) to shared-head.js

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

See https://phabricator.services.mozilla.com/D106037#inline-593121

We could extract the getTargetForTab(tab) test helper from devtools/shared/webconsole/test/browser/head.js

async function getTargetForTab(tab) {
  const target = await TabTargetFactory.forTab(tab);
  info("Attaching to the active tab.");
  await target.attach();
  return target;
}

move it to shared-head and then reuse it in all the mochitests importing shared-head which do very similar things: https://searchfox.org/mozilla-central/search?q=target.attach%28&path=devtools%2F**%2Ftest&case=false&regexp=false

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b7367a27d9a
[devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out 10 changesets (bug 1694140, bug 1694886, bug 1688688) for devtools failures on browser_CORS-console-warnings.js.
https://hg.mozilla.org/integration/autoland/rev/55019aa73595f6c194774b1999c440e1aef2bc9e

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=1b7367a27d9ab527d63ef8eac7af1111ab0eb7b9&selectedTaskRun=ff1I83nYQSC8WTxh546ZAA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=331196400&repo=autoland&lineNumber=8892

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8bec65732c5
[devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c8bec65732c5