1694909 - Remove support for texture arrays in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Nicolas Silva [:nical]]

We don't use texture arrays anymore in WebRender but we have remnants of it in many places. It would be nice to get rid of all of thes layer indices passed around (but that we assert to be zero in the end).

Comment 1

[Jamie Nicol [:jnicol]]

Is this going to include removing support from the shaders? If so, that will fix bug 1630356 and unblock adreno3xx \o/

This is a big task though so it'd be understandable to tackle it in a few chunks and we can do the shaders seperately/later

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 1 - Remove some texture array support code. r=gw

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 2 - Remove more texture array support code in WebRender. r=gw

Depends on D106476

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 3 - Remove Texture arrays from the scaling shader. r=gw

Depends on D106477

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 4 - Remove texture arrays from the composite shader. r=gw

Depends on D106478

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 5 - Remove layer parameter from draw_texture_cache_target. r=gw

Depends on D106479

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 6 - Remove the layer index from render task struct in the shaders. r=gw

Remove RenderTaskCommonData in the process and replace it with RectWithSize directly.

Depends on D106480

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 7 - Store RenderTaskData's user data as a vec4. r=gw

This replaces the vec3 with a vec4.

Depends on D106481

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 8 - Remove most remaining usage of layer index in the shaders. r=gw

Depends on D106482

Comment 10

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 9 - Remove layer from ImageSource. r=gw

Also rename the shader's ImageResource into ImageSource to match the terminology on the rust side (especially since the rust code has a different thing named ImageResource).

Depends on D106483

Comment 11

[Jamie Nicol [:jnicol]]

Yaay part 4!

Comment 12

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 10 - Remove ImageBufferKind::Texture2DArray. r=gw

Depends on D106484

Comment 13

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 11 - Remove texture array shader variations. r=gw

A small patch but probably the most impactful of this series as it removes a whole lot of generated shaders.

Depends on D106508

Comment 14

[Nicolas Silva [:nical]]

Attachment: Bug 1694909 - Part 12 - Remove the need to wrap uvs in a vec3 in shaders. r=gw

Depends on D106509

Comment 15

[Nicolas Silva [:nical]]

(In reply to Jamie Nicol [:jnicol] from comment #1)

Is this going to include removing support from the shaders? If so, that will fix bug 1630356 and unblock adreno3xx \o/

Yep, the texture array shaders are removed in part 11.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a02085ee4c8
Part 1 - Remove some texture array support code. r=gw
https://hg.mozilla.org/integration/autoland/rev/16d4c3dee954
Part 2 - Remove more texture array support code in WebRender. r=gw
https://hg.mozilla.org/integration/autoland/rev/4248f7607097
Part 3 - Remove Texture arrays from the scaling shader. r=gw
https://hg.mozilla.org/integration/autoland/rev/a585e1bbfa43
Part 4 - Remove texture arrays from the composite shader. r=gw
https://hg.mozilla.org/integration/autoland/rev/1f3eea989ac2
Part 5 - Remove layer parameter from draw_texture_cache_target. r=gw
https://hg.mozilla.org/integration/autoland/rev/3677a7a9c68d
Part 6 - Remove the layer index from render task struct in the shaders. r=gw
https://hg.mozilla.org/integration/autoland/rev/d14bba5024e8
Part 7 - Store RenderTaskData's user data as a vec4. r=gw
https://hg.mozilla.org/integration/autoland/rev/87328456c92e
Part 8 - Remove most remaining usage of layer index in the shaders. r=gw
https://hg.mozilla.org/integration/autoland/rev/e4c322dfa54d
Part 9 - Remove layer from ImageSource. r=gw
https://hg.mozilla.org/integration/autoland/rev/0b2fd64a816a
Part 10 - Remove ImageBufferKind::Texture2DArray. r=gw
https://hg.mozilla.org/integration/autoland/rev/399857337559
Part 11 - Remove texture array shader variations. r=gw
https://hg.mozilla.org/integration/autoland/rev/31199f2f0f8e
Part 12 - Remove the need to wrap uvs in a vec3 in shaders. r=gw

Comment 17

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7a02085ee4c8
https://hg.mozilla.org/mozilla-central/rev/16d4c3dee954
https://hg.mozilla.org/mozilla-central/rev/4248f7607097
https://hg.mozilla.org/mozilla-central/rev/a585e1bbfa43
https://hg.mozilla.org/mozilla-central/rev/1f3eea989ac2
https://hg.mozilla.org/mozilla-central/rev/3677a7a9c68d
https://hg.mozilla.org/mozilla-central/rev/d14bba5024e8
https://hg.mozilla.org/mozilla-central/rev/87328456c92e
https://hg.mozilla.org/mozilla-central/rev/e4c322dfa54d
https://hg.mozilla.org/mozilla-central/rev/0b2fd64a816a
https://hg.mozilla.org/mozilla-central/rev/399857337559
https://hg.mozilla.org/mozilla-central/rev/31199f2f0f8e

Comment 18

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #29007 (as of Wed, 03 Mar 2021 00:02:23 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
0.22%	installer size		osx-shippable	nightly	86,473,118.00 -> 86,285,197.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29007