1694974 - Remove all existing Fission WPT intermittents

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[u608768]

A lot of Fission code has changed, so there's probably a number of stale intermittent annotations. This will get rid of them.

This shouldn't land until we've established a way of monitoring wptsync pushes for new Fission annotations and creating bugs for each new intermittent.

Comment 1

[u608768]

Attachment: Bug 1694974 - Remove all existing Fission WPT intermittents, r?jgraham,cpeterson

Comment 2

[u608768]

This should remove annotations that have not fission as well, since those also may no longer apply.

Comment 3

[Neha Kochar [:neha]]

We can complete this in M7a with other tests enablement.

Comment 4

[u608768]

Attachment: Bug 1694974 - Remove "fission" intermittent annotations, r?cpeterson

Comment 5

[James Graham [:jgraham]]

Removing not fission annotations seems strange; they might indeed no longer apply but that's true of any intermittent annotation and removing ones that explicitly don't apply to fission as part of a patch to remove ones that explictly do apply to fission doesn't make much sense to me.

What have you done in terms of testing here?

Comment 6

[Chris Peterson [:cpeterson]]

Kashav, can you please share a Try run with your patch that shows these WPT tests are no longer intermittent failures?

Removing not fission annotations seems fine to me if other annotations already cover a superset of the not fission annotations' configuration criteria. But I defer to James' expertise here!

Comment 7

[u608768]

(In reply to James Graham [:jgraham] from comment #5)

What have you done in terms of testing here?

I removed all intermittent annotations and pushed to try and then adjusted based on failures/errors. And then repeated that until all remaining failures were known or not related.

The pushes are here:

• https://treeherder.mozilla.org/jobs?repo=try&revision=829b9d47d9254735782c1740ca2eaef4fd27d547
• https://treeherder.mozilla.org/jobs?repo=try&revision=367386596639084487878cbf8448f1d5a73b9b74
• https://treeherder.mozilla.org/jobs?repo=try&revision=47874fe69c1d7a195e73bee04106a7dc602d058a

Removing not fission annotations seems strange; they might indeed no longer apply but that's true of any intermittent annotation and removing ones that explicitly don't apply to fission as part of a patch to remove ones that explictly do apply to fission doesn't make much sense to me.

My main reason for removing these is that I suspect that many (most?) of the not fission intermittents actually have nothing to do with fission being enabled, so it made sense to start afresh on those as well. I can move those to another patch or bug if that's preferred.

Comment 8

[u608768]

Oh, oops, just now realizing that I didn't actually run those without Fission. Will split out the not fission removals and do a few pushes for those.

Comment 9

[u608768]

Attachment: WIP: Bug 1694974 - Remove "not fission" intermittent annotations, r?jgraham

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/700f42f1be2e
Remove "fission" intermittent annotations, r=webdriver-reviewers,cpeterson,whimboo

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/700f42f1be2e