1695022 - Regression: Megabar Resultlist Text is 1px too far right and no longer aligned with Address Bar Text

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mehmet]

Attachment: Bug_in_Nightly.png

Nightly 88.0a1 (2021-02-25) (64-Bit)
MacBookAir M1

1. Type Something into the Address Bar
   2.) Compare the textposition of Address Bar with Resultlist

Actual: Megabar Resultlist Text is 1px too far right and no longer aligned with Address Bar Text

Expected: Megabar Resultlist Text should be moved 1px too the left to be aligned again with Address Bar Text

This is a recent regression.

Comment 1

[Mehmet]

Attachment: Expected.png

"Expected result" screenshot from FF86.

Comment 2

[Harry Twyford]

This is almost definitely the result of bug 1691544. Could someone please verify?

Comment 3

[Catalin Sasca, Desktop QA [:csasca]]

I did twice the regression range and both times it got me here: Pushlog

Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D99893

Could this be the one? Harry mentioned that bug 1691544 may be, but the regression range got me twice to Bug 1596897.
Please let me know if I can help with anything else.

Comment 4

[Harry Twyford]

Thanks Catalin! It definitely could have been bug 1596897. That bug changed the spacing in the identity box. It also changed some CSS variables used in urlbarView.inc.css, which could have caused the problem in this bug.

Comment 5

[Harry Twyford]

This will be fixed in bug 1691545.

Comment 6

[Mehmet]

(In reply to Harry Twyford [:harry] from comment #5)

This will be fixed in bug 1691545.

Nice, thanks!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1596897

Comment 8

[Mehmet]

(In reply to Harry Twyford [:harry] from comment #5)

This will be fixed in bug 1691545.

Bug 1691545 is fixed, but this bug is still alive in latest Nightly 88.0a1 (2021-03-08) (64-Bit)

Comment 9

[Marco Bonardo [:mak]]

Hm, it seems to still be off by 1 px also after my patch in bug 1696628.

Comment 10

[Marco Bonardo [:mak]]

the problem is apparently

#identity-box[pageproxystate="invalid"] {
  margin-inline-end: calc(var(--identity-box-margin-inline) + 2px);
}

and

.urlbarView-favicon {
  margin-inline-end: calc(var(--urlbar-icon-padding) + var(--identity-box-margin-inline)));
}

in non-proton it should be

.urlbarView-favicon {
  margin-inline-end: calc(var(--urlbar-icon-padding) / 2 + var(--identity-box-margin-inline) + 2px));
}

Comment 11

[Marco Bonardo [:mak]]

tracking with the proton project. Even if it's a regression in Nightly, it was due to Proton work.

Comment 12

[Marco Bonardo [:mak]]

let's pick bug 1696628 first, that is clarifying some calculations and it'd be useful to have it in.

Comment 13

[Marco Bonardo [:mak]]

Attachment: Bug 1695022 - Address bar result list titles are misaligned by 1px. r=harry

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f345299f89d2
Address bar result list titles are misaligned by 1px. r=harry,ntim

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f345299f89d2

Comment 16

[Mehmet]

I can confirm it is fixed in Nightly 88.0a1 (2021-03-10). Thanks :)

Comment 17

[Marco Bonardo [:mak]]

Thank you for reporting the problem!

Comment 18

[Marco Bonardo [:mak]]

I'm wontfixing 87 because the fix depends on previous cleanup work that happens in 88, it doesn't seem worth to spend much time into a 1 px text shift for a single version.

Comment 19

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We verified this issue using Fx 88.0b5 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 LTS.