Closed Bug 1695084 Opened 7 months ago Closed 7 months ago

Update copy for permission panel: Persistent Storage

Categories

(Firefox :: Site Permissions, task, P3)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mconley, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers])

Attachments

(1 file)

We're still waiting on what the exact strings are, but this bug will be updated as soon as we have them.

Don't bother converting the strings to Fluent. Just update the .properties file, and make sure to rev the string ID.

The code powering the Persistent Storage Permission panel is here: https://searchfox.org/mozilla-central/rev/6f8f3d0e9022b6f0405da26ec940a89455416202/browser/modules/PermissionUI.jsm#1051-1132

We've got copy back. The new string should be:

Allow %S to store data in persistent storage?

With the choice buttons changed to "Allow" and "Block", respectively.

The strings can be found here: https://searchfox.org/mozilla-central/rev/f1159268add2fd0959e9f91b474f5da74c90f305/browser/locales/en-US/chrome/browser/browser.properties#633-640

We're going to remove the split button here, and instead opt for the checkbox for "Remember this decision". This checkbox is kinda meaningless in the "allow" case (since we always remember this decision), but makes more sense in the "block" case.

Keywords: helpwanted
Priority: P5 → P3
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a64ec906ba99
Update persistent storage permission prompt. r=mconley,flod

Backed out for causing browser-chrome failures in browser_PermissionUI_prompts.

Backout link: https://hg.mozilla.org/integration/autoland/rev/74781d5a8b3d4adacc054ee943a2ab0dc5035f30

Push with failures

Failure log

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34f7e105340a
Update persistent storage permission prompt. r=mconley,flod
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74f818e48e1a
Update persistent storage permission prompt. r=mconley,flod
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.