1695084 - Update copy for permission panel: Persistent Storage

Status: RESOLVED FIXED

(Firefox :: Site Permissions, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

We're still waiting on what the exact strings are, but this bug will be updated as soon as we have them.

Don't bother converting the strings to Fluent. Just update the .properties file, and make sure to rev the string ID.

The code powering the Persistent Storage Permission panel is here: https://searchfox.org/mozilla-central/rev/6f8f3d0e9022b6f0405da26ec940a89455416202/browser/modules/PermissionUI.jsm#1051-1132

Comment 1

[Mike Conley (:mconley) (:⚙️)]

We've got copy back. The new string should be:

Allow %S to store data in persistent storage?

With the choice buttons changed to "Allow" and "Block", respectively.

The strings can be found here: https://searchfox.org/mozilla-central/rev/f1159268add2fd0959e9f91b474f5da74c90f305/browser/locales/en-US/chrome/browser/browser.properties#633-640

We're going to remove the split button here, and instead opt for the checkbox for "Remember this decision". This checkbox is kinda meaningless in the "allow" case (since we always remember this decision), but makes more sense in the "block" case.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1695084 - Update persistent storage permission prompt. r=mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a64ec906ba99
Update persistent storage permission prompt. r=mconley,flod

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_PermissionUI_prompts.

Backout link: https://hg.mozilla.org/integration/autoland/rev/74781d5a8b3d4adacc054ee943a2ab0dc5035f30

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34f7e105340a
Update persistent storage permission prompt. r=mconley,flod

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 34f7e105340a (bug 1695084) for bc failures at browser_permissionsPromptDeny.js.
https://hg.mozilla.org/integration/autoland/rev/6bba599e92db99549f13f04df11402cff8532c1f

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=34f7e105340a75fe71df2b19fca4b144d591cd5e&selectedTaskRun=XqvE71LpSP6bN4X6ZDY74g.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=332085207&repo=autoland&lineNumber=21790

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74f818e48e1a
Update persistent storage permission prompt. r=mconley,flod

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/74f818e48e1a