Closed
Bug 1695120
Opened 4 years ago
Closed 2 years ago
Remove unused BlocksRingBuffer
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: mozbugz, Assigned: neel, Mentored)
References
Details
(Whiteboard: [fxp-profiler])
Attachments
(1 file)
BlocksRingBuffer is not used anymore since bug 1630872.
BlocksRingBuffer.h is not even included from Firefox code anymore (so at least it doesn't take space). But it's included in test code, adding to the build time, and polluting searchfox.
It would be good to remove it, mostly to lessen the cognitive load.
It had some good test coverage though, it would be worth considering moving some tests to the new buffer implementation. (That's the main reason I haven't "just" deleted the header.)
|
||
Updated•3 years ago
|
Mentor: canaltinova
Whiteboard: [fxp]
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Whiteboard: [fxp] → [fxp-profiler]
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → neel
Status: NEW → ASSIGNED
See Also: → 1868554
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a035ddfc75fc
Remove unused BlocksRingBuffer r=profiler-reviewers,canaltinova
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•