1695135 - New window has no focus by window.open after window.close is called with Fission and xorigin

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Makoto Kato [:m_kato]]

Attachment: focus-fission-xorign

Attached mochitest works on non-fission (./mach mochitest dom/base/test/test_window_focus_by_close_and_open.html), but when running this with fission+xorigin (./mach mochitest --enable-fission --enable-xorigin-tests dom/base/test/test_window_focus_by_close_and_open.html), this isn't finished since 2nd new window cannot have focus. This occurs on APZ mochitests such as bug 1681211.

I guess that root cause is race condition since PBrowserBridge.Activate is async.

When window is closed, window focus is back to other window. So the focus of this test tries moving to parent window (test_window_focus_by_close_and_window.html). But since Activate is async, before backing focus to parent window, new window by window.open takes focus. Then, the focus moves to parent window unfortunately by window raised via async IPC call that is called before new window takes focus.

Comment 1

[Neha Kochar [:neha]]

Edgar, can you look into this, please?

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Neha Kochar [:neha] from comment #1)

Edgar, can you look into this, please?

Sure, I will take a look.

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

I could not reproduce this after applying patches of bug 1691892 and bug 1696908.

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Okay, I check again, the patch in bug 1696908 fix this.

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1695135 - Add test for window focus by calling window.close() and window.open();

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6805fd964bd5
Add test for window focus by calling window.close() and window.open(); r=hsivonen

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6805fd964bd5