1695153 - Remove NewObjectWithGroup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

Spinning this off from bug 1689413.

NewObjectWithGroup was useful when we had allocation-site groups, because creating a new group based on Class + proto would use the default group so we needed a way to pass in another group. Now that groups are always determined by Class/proto/realm, there's no longer a difference in behavior.

NewObjectWithGroup can be faster for some callers because it doesn't require looking up the group, but with groups going away soon in bug 1689413 that will no longer apply.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1695153 part 1 - Stop using NewObjectWithGroup in the typed array code. r?iain!

TI used allocation site groups here and passing around the group helped avoid
some overhead there.

Note that the group was passed only if the group's proto was the default proto
for the typed array class.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1695153 part 2 - Inline makeTypedInstance into the caller. r?iain!

Depends on D106594

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1695153 part 3 - Remove TI-related code in makeInstance. r?iain!

The "more TI optimizations" comment refers to allocation site groups and the
ability to use singletons for large typed arrays. Both of these have since
been removed.

Depends on D106595

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1695153 part 4 - Remove other NewObjectWithGroup callers. r?iain!

Worst-case this adds an ObjectGroup lookup, but that will go away when ObjectGroups
are removed and NewObjectWithGivenTaggedProto can use the NewObjectCache to bypass
that lookup.

Depends on D106596

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1695153 part 5 - Remove NewObjectWithGroup. r?iain!

Depends on D106597

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1695153 part 6 - Remove now unused group code from NewObjectCache. r?iain!

Also removes references to object parents from the comment. This was an old
SpiderMonkey 'feature'.

Depends on D106598

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/362cb95705e5
part 1 - Stop using NewObjectWithGroup in the typed array code. r=iain
https://hg.mozilla.org/integration/autoland/rev/f0970b8ad3d0
part 2 - Inline makeTypedInstance into the caller. r=iain
https://hg.mozilla.org/integration/autoland/rev/1038b75f6357
part 3 - Remove TI-related code in makeInstance. r=iain
https://hg.mozilla.org/integration/autoland/rev/0a2599125529
part 4 - Remove other NewObjectWithGroup callers. r=iain
https://hg.mozilla.org/integration/autoland/rev/c57ee1144845
part 5 - Remove NewObjectWithGroup. r=iain
https://hg.mozilla.org/integration/autoland/rev/bed377ea722c
part 6 - Remove now unused group code from NewObjectCache. r=iain

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/362cb95705e5
https://hg.mozilla.org/mozilla-central/rev/f0970b8ad3d0
https://hg.mozilla.org/mozilla-central/rev/1038b75f6357
https://hg.mozilla.org/mozilla-central/rev/0a2599125529
https://hg.mozilla.org/mozilla-central/rev/c57ee1144845
https://hg.mozilla.org/mozilla-central/rev/bed377ea722c