Open Bug 1695179 Opened 4 years ago

Rename Toolbox/Host raise method to use a more meaningful name

Categories

(DevTools :: General, task, P3)

task

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

The raise parameter used in gDevTools.showToolbox can be quite cryptic https://phabricator.services.mozilla.com/D106539#inline-595608

It will end up calling the raise implementation of the corresponding ToolboxHost. See all the code matching raise at https://searchfox.org/mozilla-central/search?q=raise&path=devtools**framework%2Ftoolbox&case=false&regexp=false

We could rename the parameter/event/methods to more meaningful names, eg focusHost, bringHostToFront. Keeping in mind the implementation of raise depends on the host type and the name should be generic enough to match implementations.

You need to log in before you can comment on or make changes to this bug.