Closed Bug 1695197 Opened 8 months ago Closed 8 months ago

Unconditionally enable Glean in Firefox builds

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

Details

Attachments

(3 files)

From https://bugzilla.mozilla.org/show_bug.cgi?id=1685406#c2:

Additional requirement: Due to bug 1670261 stalled due to new gecko+nimbus+a-s+glean megazord proposal, this should also provide an ability to instrument using Glean APIs in C++/JS without Glean actually being present in the build. (Glean No-op or GNop)

As a result C++ and JS APIs and generated metrics will be unconditionally present in Gecko.

We can do that part now.

We enable compilation of FOG/Glean on all platforms.
We disable Glean initialization and metric recording on Android (GeckoView) by respecting MOZ_GLEAN_ANDROID.
This way GeckoView just works, consumers don't need to think about it (except in tests, these need to be disabled for Android builds).

Stubbing out the metric implementations will happen in the commits after
this one.

GNop = Glean No-op.
This disables all control and recording functionality when build for
Android.

Depends on D106766

We ensure nothing in this library is called from the C++ side.

Depends on D106767

See Also: → 1670261
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/233230cc7cb2
Remove MOZ_GLEAN constant, introduce MOZ_GLEAN_ANDROID. r=chutten,emilio
https://hg.mozilla.org/integration/autoland/rev/2eaa66d45695
Turn FOG into a GNop* on Android. r=chutten
https://hg.mozilla.org/integration/autoland/rev/4c3019f2af09
Don't build FOG's Rust internals on Android. r=chutten
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.