1695197 - Unconditionally enable Glean in Firefox builds

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1685406#c2:

Additional requirement: Due to bug 1670261 stalled due to new gecko+nimbus+a-s+glean megazord proposal, this should also provide an ability to instrument using Glean APIs in C++/JS without Glean actually being present in the build. (Glean No-op or GNop)

As a result C++ and JS APIs and generated metrics will be unconditionally present in Gecko.

We can do that part now.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1695197 - Remove MOZ_GLEAN constant, introduce MOZ_GLEAN_ANDROID. r?chutten

We enable compilation of FOG/Glean on all platforms.
We disable Glean initialization and metric recording on Android (GeckoView) by respecting MOZ_GLEAN_ANDROID.
This way GeckoView just works, consumers don't need to think about it (except in tests, these need to be disabled for Android builds).

Stubbing out the metric implementations will happen in the commits after
this one.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1695197 - Turn FOG into a GNop* on Android. r?chutten

GNop = Glean No-op.
This disables all control and recording functionality when build for
Android.

Depends on D106766

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1695197 - Don't build FOG's Rust internals on Android. r?chutten

We ensure nothing in this library is called from the C++ side.

Depends on D106767

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/233230cc7cb2
Remove MOZ_GLEAN constant, introduce MOZ_GLEAN_ANDROID. r=chutten,emilio
https://hg.mozilla.org/integration/autoland/rev/2eaa66d45695
Turn FOG into a GNop* on Android. r=chutten
https://hg.mozilla.org/integration/autoland/rev/4c3019f2af09
Don't build FOG's Rust internals on Android. r=chutten

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/233230cc7cb2
https://hg.mozilla.org/mozilla-central/rev/2eaa66d45695
https://hg.mozilla.org/mozilla-central/rev/4c3019f2af09