1695199 - [Reader mode] Visited links in dark mode aren't contrasted enough still

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: image.png

In bug 1546213 we addressed accessiiblity concerns about the link colors in the reader mode.

However we realized today that the visited link in dark mode uses an alpha color, and it looks like this alpha color isn't used in this context. As a result the visited link is still not contrasted enough (and TBH it isn't nice either) (see attachment).

Steps to reproduce:

1. Go on a web page where you can activate the reader view. This one for example: https://en.wikipedia.org/wiki/Web_Accessibility_Initiative
2. Click on any link to have a visited link, then come back.
3. Click on the reader view button in the address bar
4. Go on the appearance menu and activate dark mode.
5. Contrast for visited links is too low.

(NOTE: we can't use the accessibility panel to check this, because of bug 1695198)

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Hey Gijs, do you think the fact that alpha colors don't work is expected? In that case we can use a color without alpha colors.
Otherwise maybe there's an underlying bug...

Comment 2

[:Gijs (he/him)]

(In reply to Julien Wajsberg [:julienw] from comment #1)

Hey Gijs, do you think the fact that alpha colors don't work is expected? In that case we can use a color without alpha colors.
Otherwise maybe there's an underlying bug...

So, to be clear, the visited link colour in reader mode set to its dark theme is supposed to be rgba(255, 26, 217, 0.3). But the result of changing 0.3 to 0.1 or 1 is... nothing. It doesn't look like we care about the alpha value. Emilio, why is that? I don't see anything on https://developer.mozilla.org/en-US/docs/Web/CSS/color suggesting it shouldn't work.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is part of the :visited restrictions to avoid leaking the whole browser history to pages. It is documented here.

Comment 4

[:Gijs (he/him)]

So I don't really know what the desired outcome here is supposed to be (ie if the specified alpha-containing colour would have better contrast if it were semi-transparent - seems unlikely?), but given the background is known we can pre-multiply the value we want and use that, right? Julien, are you interested in providing a patch here?

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

I'll have some work to do on m-c this week so I can have a look at this passing-by.

The current value wouldn't work (contrast is 1.34) anyway, not sure why our designer gave it to us...

In the original bug, I was suggesting a much lighter #e675fd (contrast is 5.01). Contrast-finder.org suggested #E76ECA (contrast 4.5) when I submitted the previous #B5007F.
From the previous rgb(255, 26, 217), I get #FF4FE3, , but I think it is too agressive...

My preference is still with the lighter #e675fd.
If any of you do prefer #E76ECA please say it though :-)

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1695199 - Fix the contrast of visited links in the reader's dark mode r=gijs!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7f22a105446
Fix the contrast of visited links in the reader's dark mode r=Gijs

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 9206148 [details]
Bug 1695199 - Fix the contrast of visited links in the reader's dark mode r=gijs!

Beta/Release Uplift Approval Request

• User impact if declined: The visited links aren't contrasted enough in the reader with the dark mode, which is a problem for our users with color vision deficiencies.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is only a color change in a CSS variable that's used in one place only, so there is virtually no risk.
• String changes made/needed: none

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: With the fix

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f7f22a105446

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9206148 [details]
Bug 1695199 - Fix the contrast of visited links in the reader's dark mode r=gijs!

approved for 87.0b6

Comment 12

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b66de8123aa7

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Confirming the fix with the STR from the description using:

• Nightly 88.0a1 (buildID 20210309094921)
• Firefox 87.0b7 (buildID 20210307185839).