1695227 - [wayland] Set the OcclusionStateChanged() when inactive

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Robert Mader [:rmader]]

This is a follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1693513#c34:

Inactive docshells also have other power-saving behaviors, like firing setTimeout at lower rates. It sounds like the wayland frame callback driven "deactivation" would not give you that benefit, it would only pause the refresh driver.

I see two possibilities to do this:

1. add some heuristic around frame callbacks. For example in WaylandVsyncSource set the state to inactive if there hasn't been a callback for one second or so.
2. Work out an explicit Wayland protocol for this, see https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/38

Note that the most pressing issue, suspending rendering, has already been fixed in bug 1629140

Comment 1

[Robert Mader [:rmader]]

A proper protocol is almost ready now: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/99

Comment 2

[Martin Stránský [:stransky] (ni? me)]

If you don't mind Robert I'm going to implement that on top of Bug 1786247. We may monitor frame callback rate for every window and send occlusion state when the window doesn't get any.

Comment 3

[Robert Mader [:rmader]]

Sure, please go ahead! I would have myself if I had more time :(

Comment 4

[Martin Stránský [:stransky] (ni? me)]

We may also set OcclusionStateChanged() if the window is minimized. In such case we're still getting frame callbacks (why?) but the window itself is hidden.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

https://phabricator.services.mozilla.com/D125061 may be used as a template.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1695227 [Wayland] Set the OcclusionStateChanged() when inactive r?emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57fae052b308
[Wayland] Set the OcclusionStateChanged() when inactive r=emilio

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/57fae052b308