Closed Bug 1695299 Opened 4 years ago Closed 4 years ago

Update copy for permission panel: WebMIDI

Categories

(Firefox :: Site Permissions, task, P3)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mconley, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers])

Attachments

(1 file)

Don't bother converting the strings to Fluent. Just update the .properties file, and make sure to rev the string ID.

The code powering the WebMIDI Permission panel is here: https://searchfox.org/mozilla-central/rev/df23c6e58c6be1eb8399e475878f73d4867bef87/browser/modules/PermissionUI.jsm#939-1047

The strings are here: https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/browser/locales/en-US/chrome/browser/browser.properties#990-995

The new strings are:

Allow %S to access your MIDI devices?

and "Allow" and "Block" for those actions, respectively.

Note that there appear to be a few variations on the main string: https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/browser/locales/en-US/chrome/browser/browser.properties#997-1000

If applying similar changes to those are not immediately obvious, we should consult betsymikel to see what we should use instead.

No longer depends on: 1695085
Priority: P5 → P3
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a422fe2c3443
Update strings in midi permission prompt. r=mconley,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: