Closed Bug 1695320 Opened 3 years ago Closed 3 years ago

Update copy on DoH PopupNotification

Categories

(Firefox :: Messaging System, task, P3)

task

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: mconley, Assigned: andreio)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted)

Attachments

(1 file)

The "affirmative" action on that PopupNotification is "OK, Got it", and it should be changed to "Okay".

Priority: P5 → P3
Assignee: nobody → andrei.br92
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c5cb052e61b
Update copy on DoH PopupNotification r=flod,fluent-reviewers

Backed out for failures on browser_cleanFlow.js

backout: https://hg.mozilla.org/integration/autoland/rev/d7ac4f428c4de589f94b833e604384de2683acac

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=5c5cb052e61bd4829c55f313268b8a9a3490deab&searchStr=browser-chrome&selectedTaskRun=YyMdjZBrRpezrpXy8bfIiw.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=332538450&repo=autoland&lineNumber=2945

[task 2021-03-09T14:33:14.357Z] 14:33:14 INFO - TEST-UNEXPECTED-FAIL | browser/components/doh/test/browser/browser_cleanFlow.js | Test timed out -
[task 2021-03-09T14:33:14.357Z] 14:33:14 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-03-09T14:33:14.358Z] 14:33:14 INFO - TEST-UNEXPECTED-FAIL | browser/components/doh/test/browser/browser_cleanFlow.js | A promise chain failed to handle a rejection: [fluent] Missing translations in en-US: cfr-doorhanger-doh-primary-button. - stack: (No stack available.)
[task 2021-03-09T14:33:14.358Z] 14:33:14 INFO - Rejection date: Tue Mar 09 2021 14:31:16 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 285
[task 2021-03-09T14:33:14.358Z] 14:33:14 INFO - Stack trace:
[task 2021-03-09T14:33:14.358Z] 14:33:14 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:285
[task 2021-03-09T14:33:14.359Z] 14:33:14 INFO - chrome://mochikit/content/browser-test.js:nextTest:631
[task 2021-03-09T14:33:14.359Z] 14:33:14 INFO - GECKO(2700) | MEMORY STAT | vsize 130550962MB | residentFast 1632MB
[task 2021-03-09T14:33:14.360Z] 14:33:14 INFO - TEST-OK | browser/components/doh/test/browser/browser_cleanFlow.js | took 120135ms

Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/184cf0e0667c
Update copy on DoH PopupNotification r=flod,fluent-reviewers
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Flags: needinfo?(andrei.br92)

I have verified this task I can confirm that the "OK, Got it" button from the "DOH_ROLLOUT_CONFIRMATION_89 " message was successfully changed into the "Okay" one.

Verified using the latest Firefox Nightly (88.0a1 Build ID - 20210312033752) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: