1695323 - Update copy for permission panel: Canvas

Status: RESOLVED FIXED

(Firefox :: Site Permissions, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Don't bother converting the strings to Fluent. Just update the .properties file, and make sure to rev the string ID.

The code powering the Canvas Permission panel is here: https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/browser/base/content/browser.js#7547-7637

The strings are here: https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/browser/locales/en-US/chrome/browser/browser.properties#417-422

The new strings are:

Allow %S to use your HTML5 canvas image data? This may be used to uniquely identify your computer.

and "Allow" and "Block" for those actions, respectively. Also update the checkbox string to "Remember this decision".

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1695323 - Update canvas permission panel strings. r=mconley

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Gentle poke here - emilio, are you still working on this?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yup yup, updated :)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1695323 - Allow close icon to grow vertically if needed. r=jaws,mconley

Otherwise notification close icons like the canvas one look stretched
because of this rule:

https://searchfox.org/mozilla-central/rev/5a66c4b4a41ab78a87c30c9db0d93c732c534402/toolkit/themes/shared/notification.css#124

Which grow the content of the icon.

Depends on D107053

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1695323 - Allow close icon to grow vertically if needed. r=jaws,mconley

Otherwise notification close icons like the canvas one look stretched
because of this rule:

https://searchfox.org/mozilla-central/rev/5a66c4b4a41ab78a87c30c9db0d93c732c534402/toolkit/themes/shared/notification.css#124

Which grow the content of the icon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08222505d32b
Allow close icon to grow vertically if needed. r=jaws

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d87164b83bf9
Update canvas permission panel strings. r=mconley,flod

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/08222505d32b
https://hg.mozilla.org/mozilla-central/rev/d87164b83bf9