1695328 - PerformanceObserver should throw type errors instead of syntax errors

Status: RESOLVED FIXED

(Core :: Performance: General, defect)

Description

[Sean Feng [:sefeng211]]

The latest spec indicates that type error should be thrown for performance observer https://w3c.github.io/performance-timeline/#observe-method. However, we throw syntax errors in our code.

Comment 1

[Sean Feng [:sefeng211]]

Attachment: Bug 1695328 - PerformanceObserver should throw TypeError instead of SyntaxError r=bdekoz,smaug!

According to the latest spec
https://w3c.github.io/performance-timeline/#observe-method,
TypeError should be thrown, however we throw SyntaxError.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60a3eddb183b
PerformanceObserver should throw TypeError instead of SyntaxError r=smaug

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing perma failures in PerformanceObserver.

Backout link: https://hg.mozilla.org/integration/autoland/rev/56a02be0b299b4333340050b9674d0ed71898f46

Push with failures

Failure log

INFO - TEST-PASS | dom/performance/tests/test_performance_observer.html | Expected 'TypeError', got 'TypeError'.
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - Buffered messages finished
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - TEST-UNEXPECTED-FAIL | dom/performance/tests/test_performance_observer.html | Expected 'SyntaxError', got 'TypeError'.
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - assert_throws@dom/performance/tests/test_performance_observer.html:79:7
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - @dom/performance/tests/test_performance_observer.js:22:16
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - promise_test/<@dom/performance/tests/test_performance_observer.html:25:13
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - runNextTest@dom/performance/tests/test_performance_observer.html:54:17
[task 2021-03-01T15:02:53.394Z] 15:02:53 INFO - promise_test/<@dom/performance/tests/test_performance_observer.html:42:7
[task 2021-03-01T15:02:53.395Z] 15:02:53 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - TEST-UNEXPECTED-FAIL | dom/performance/tests/test_performance_observer.html | Expected 'SyntaxError', got 'TypeError'.
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - assert_throws@dom/performance/tests/test_performance_observer.html:79:7
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - @dom/performance/tests/test_performance_observer.js:30:16
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - promise_test/<@dom/performance/tests/test_performance_observer.html:25:13
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - runNextTest@dom/performance/tests/test_performance_observer.html:54:17
[task 2021-03-01T15:02:53.397Z] 15:02:53 INFO - promise_test/<@dom/performance/tests/test_performance_observer.html:42:7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d063cae49ad3
PerformanceObserver should throw TypeError instead of SyntaxError r=smaug

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d063cae49ad3