Update copy for WebExtension install approval panel
Categories
(WebExtensions :: Frontend, task, P3)
Tracking
(Not tracked)
People
(Reporter: mconley, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-door-hangers])
Attachments
(3 files)
The strings for the WebExtension install panel are getting updated. It's a little spread out, but I think the code that powers the strings in the panel are here: https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/toolkit/components/extensions/Extension.jsm#1569-1773
We don't need to convert these to Fluent, just update the .properties file, and rev the ID of the string.
A few changes:
- The header should be updated to
"Add %S? This extension will have permission to:"
- We're removing the list intro string
webextPerms.learnMore
should be updated to"Learn more"
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
The text wrapping in the header looks a bit off to me, maybe we should just change the listIntro string?
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43fc3866aabe Update WebExtension approval panel for Proton. r=mconley,robwu
Comment 4•3 years ago
|
||
bugherder |
Reporter | ||
Comment 5•3 years ago
|
||
Gentle poke here - emilio, are you still working on this?
Assignee | ||
Comment 6•3 years ago
|
||
Yup, yup. Question though. So when an extension is unsigned, right now we do:
Add <extension>?
Caution: This add-on is unverified. Malicious add-ons can steal your private information or compromise your computer. Only install this add-on if you trust the source.
This extension will have permission to:
How should we arrange stuff in that case?
Reporter | ||
Comment 7•3 years ago
|
||
Hey emilio,
Let's keep roughly the same pattern as with signed extensions, and have the string be:
Add <extension>? This add-on is unverified. Malicious add-ons can steal your private information or compromise your computer. Only install this add-on if you trust the source. This extension will have permission to:
Assignee | ||
Comment 9•3 years ago
|
||
I don't know if this works fine for RTL languages... Itiel do you know?
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
The content team didn't have visibility over all the variants (in the inventory, there's only a signed add-on with permissions, not even one without any permissions).
Betsy is looking into this and should have a proposal.
Comment 11•3 years ago
•
|
||
New strings for unsigned extensions.
Unsigned add-on with permissions
Add %S? This extension is unverified. Malicious extensions can steal your private information or compromise your computer. Only add it if you trust the source. This extension will have permission to:
Unsigned add-on without permissions
Add %S? This extension is unverified. Malicious extensions can steal your private information or compromise your computer. Only add it if you trust the source.
Reporter | ||
Comment 12•3 years ago
|
||
Does comment 11 give you what you need, emilio?
Comment 13•3 years ago
|
||
I'm wondering if "unverified" in the UI is an issue since we also may use "verified" to mean human-reviewed on AMO. IOW un/verified is related to addon review process rather than the signed state.
Unsigned addons are only allowed via about:debugging.
Assignee | ||
Updated•3 years ago
|
Comment 15•3 years ago
|
||
Thanks @mixedpuppy, you bring up a good point. We may be able to revisit the language in the future
Updated•3 years ago
|
Comment 16•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c81efb7a797f Tweak extension approval panel layout so that the messages are inline. r=mconley,robwu
Comment 17•3 years ago
|
||
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4a6bcc18a7e Backed out changeset c81efb7a797f for xpcshell failures on test_ext_permission_warnings.js. CLOSED TREE
Comment 18•3 years ago
|
||
Failure log: https://treeherder.mozilla.org/logviewer?job_id=333885816&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/d4a6bcc18a7e2b6d3c5400c3f0a6abf5dfc3a1f0
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 19•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9e488d1ad81 Tweak extension approval panel layout so that the messages are inline. r=mconley,robwu
Comment 20•3 years ago
|
||
bugherder |
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 21•3 years ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/2198df4461dc Port bug 1695338 - Tweak extension approval panel layout so that the messages are inline. rs=bustage-fix
Description
•