1695338 - Update copy for WebExtension install approval panel

Status: RESOLVED FIXED

(WebExtensions :: Frontend, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

The strings for the WebExtension install panel are getting updated. It's a little spread out, but I think the code that powers the strings in the panel are here: https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/toolkit/components/extensions/Extension.jsm#1569-1773

We don't need to convert these to Fluent, just update the .properties file, and rev the ID of the string.

A few changes:

• The header should be updated to "Add %S? This extension will have permission to:"
• We're removing the list intro string
• webextPerms.learnMore should be updated to "Learn more"

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: With changes as requested.

The text wrapping in the header looks a bit off to me, maybe we should just change the listIntro string?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1695338 - Update WebExtension approval panel for Proton. r=mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43fc3866aabe
Update WebExtension approval panel for Proton. r=mconley,robwu

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/43fc3866aabe

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Gentle poke here - emilio, are you still working on this?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Yup, yup. Question though. So when an extension is unsigned, right now we do:

Add <extension>?

Caution: This add-on is unverified. Malicious add-ons can steal your private information or compromise your computer. Only install this add-on if you trust the source.

This extension will have permission to:

How should we arrange stuff in that case?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey emilio,

Let's keep roughly the same pattern as with signed extensions, and have the string be:

Add <extension>? This add-on is unverified. Malicious add-ons can steal your private information or compromise your computer. Only install this add-on if you trust the source. This extension will have permission to:

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Alright.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1695338 - Tweak extension approval panel layout so that the messages are inline. r=mconley,robwu

I don't know if this works fine for RTL languages... Itiel do you know?

Comment 10

[Francesco Lodolo [:flod]]

The content team didn't have visibility over all the variants (in the inventory, there's only a signed add-on with permissions, not even one without any permissions).

Betsy is looking into this and should have a proposal.

Comment 11

[Betsy Mikel [:betsymi]]

New strings for unsigned extensions.

Unsigned add-on with permissions
Add %S? This extension is unverified. Malicious extensions can steal your private information or compromise your computer. Only add it if you trust the source. This extension will have permission to:

Unsigned add-on without permissions
Add %S? This extension is unverified. Malicious extensions can steal your private information or compromise your computer. Only add it if you trust the source.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Does comment 11 give you what you need, emilio?

Comment 13

[Shane Caraveo (:mixedpuppy)]

I'm wondering if "unverified" in the UI is an issue since we also may use "verified" to mean human-reviewed on AMO. IOW un/verified is related to addon review process rather than the signed state.

Unsigned addons are only allowed via about:debugging.

Comment 14

[Shane Caraveo (:mixedpuppy)]

for comment 13

Comment 15

[Betsy Mikel [:betsymi]]

Thanks @mixedpuppy, you bring up a good point. We may be able to revisit the language in the future

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c81efb7a797f
Tweak extension approval panel layout so that the messages are inline. r=mconley,robwu

Comment 17

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4a6bcc18a7e
Backed out changeset c81efb7a797f for xpcshell failures on test_ext_permission_warnings.js. CLOSED TREE

Comment 18

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CofB2NTKQhiI6O-FzUJ89Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=xpc&revision=c81efb7a797fb8da2d14e15c4692ab1791a7028f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=333885816&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d4a6bcc18a7e2b6d3c5400c3f0a6abf5dfc3a1f0

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9e488d1ad81
Tweak extension approval panel layout so that the messages are inline. r=mconley,robwu

Comment 20

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f9e488d1ad81

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2198df4461dc
Port bug 1695338 - Tweak extension approval panel layout so that the messages are inline. rs=bustage-fix