1695345 - Add a new, Nightly-only temporary built-in theme called Proton Dark where we can develop the Proton dark theme

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Mike Conley (:mconley) (:⚙️)]

The idea is to fork the built-in Dark theme, and do development for Proton Dark in that fork so as to not disrupt folks that don't have Proton enabled.

Then, when we reach a ship release vehicle, to merge those changes into the main-line Dark theme, and remove the separate Proton Dark theme.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1695345 - Fork Dark Mode compact theme for Proton. r?mixedpuppy!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey mixedpuppy, how practical is the plan in comment 0? One of the things I've noticed is that if I flip the browser.proton.enabled pref on to add the built-in addon, go to about:addons, I can see the theme... but then if I flip the pref off and restart, I still see the theme in about:addons.

I suspect there's some persistence going on in extensions.json. Presuming we go with this plan, what's the best way to clean up after ourselves once we're done with the forked theme?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(And normally I'd host the theme on AMO, but we're expecting to use a bunch of "theme experiments" stuff to set Proton Dark Mode colours)

Comment 4

[Shane Caraveo (:mixedpuppy)]

Does this addon need to be on release, or can it be on nightly only?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Does this addon need to be on release, or can it be on nightly only?

It should never reach release - it's for Nightly-only.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

So before I land this, I want to think this through to its conclusion, where we copy the colour values over to the "actual" Dark Mode and Default Theme dark manifests... is there any cleanup we'd need to do for Nightly users to remove the Nightly-only Proton Dark Mode from the extensions.json file? See comment 2.

Comment 7

[Shane Caraveo (:mixedpuppy)]

answered on teh patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3251eaf83891
Fork Dark Mode compact theme for Proton. r=mixedpuppy

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for causing build bustages.

backout: https://hg.mozilla.org/integration/autoland/rev/1c451f48c821b36c001f3f31923350696761e4e7

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=3251eaf838911cb02490d91e900ef7b6365c3f41&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=331674488&repo=autoland&lineNumber=68022

[task 2021-03-02T01:12:44.002Z] 01:12:44 INFO - package> ERROR: The following duplicated files are not allowed:
[task 2021-03-02T01:12:44.002Z] 01:12:44 INFO - package> Firefox NightlyDebug.app/Contents/Resources/browser/chrome/browser/content/builtin-themes/dark/experiment.css
[task 2021-03-02T01:12:44.002Z] 01:12:44 INFO - package> Firefox NightlyDebug.app/Contents/Resources/browser/chrome/browser/content/builtin-themes/proton-dark/experiment.css
[task 2021-03-02T01:12:44.002Z] 01:12:44 INFO - package> Firefox NightlyDebug.app/Contents/Resources/browser/chrome/browser/content/builtin-themes/dark/icon.svg
[task 2021-03-02T01:12:44.002Z] 01:12:44 INFO - package> Firefox NightlyDebug.app/Contents/Resources/browser/chrome/browser/content/builtin-themes/proton-dark/icon.svg
[task 2021-03-02T01:12:44.002Z] 01:12:44 ERROR - package> make[5]: *** [/builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.mk:26: stage-package] Error 1
[task 2021-03-02T01:12:44.002Z] 01:12:44 INFO - package> make[5]: Leaving directory '/builds/worker/workspace/obj-build/browser/installer'
[task 2021-03-02T01:12:44.003Z] 01:12:44 ERROR - package> make[4]: *** [/builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.mk:111: make-package] Error 2
[task 2021-03-02T01:12:44.003Z] 01:12:44 ERROR - package> make[3]: *** [/builds/worker/checkouts/gecko/config/rules.mk:355: default] Error 2
[task 2021-03-02T01:12:44.003Z] 01:12:44 ERROR - package> make[2]: *** [/builds/worker/checkouts/gecko/browser/build.mk:6: package] Error 2
[task 2021-03-02T01:12:44.003Z] 01:12:44 ERROR - make[1]: *** [/builds/worker/checkouts/gecko/build/moz-automation.mk:110: automation/package] Error 2
[task 2021-03-02T01:12:44.003Z] 01:12:44 INFO - make[1]: *** Waiting for unfinished jobs....

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55b0990074bc
Fork Dark Mode compact theme for Proton. r=mixedpuppy

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/55b0990074bc