1697062 - Add temporary Proton Light theme

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Tim Nguyen :ntim]

+++ This bug was initially created as a clone of Bug #1695345 +++

The idea is to fork the built-in Light theme, and do development for Proton Light in that fork so as to not disrupt folks that don't have Proton enabled.

Then, when we reach a ship release vehicle, to merge those changes into the main-line Light theme, and remove the separate Proton Light theme.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1697062 - Add temporary Proton Light theme. r=jaws

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1697062 - Update Proton Light theme to match specification.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2cbc95f6826
Add temporary Proton Light theme. r=jaws
https://hg.mozilla.org/integration/autoland/rev/bf5e51c186a6
Update Proton Light theme to match specification. r=jaws

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f2cbc95f6826
https://hg.mozilla.org/mozilla-central/rev/bf5e51c186a6

Comment 5

[Petruta Horea [:phorea], Desktop Test Engineering]

Hi Tim,

I noticed that Proton Light & Proton Dark themes are not persistent across sessions (after restart, the Default theme gets reenabled).

Also, Hamburger panel loses it's border with Proton Light theme, and it stays like these even after switching the theme back to default.

I wonder if we should fill these bugs since the work on themes is still in progress. We were actually testing different parts of Proton and we must cover Light and Dark theme.

Thank you!

Comment 6

[Tim Nguyen :ntim]

Regarding persistence, Proton Light/Proton Dark should be removed and replace Light/Dark when the time comes, so not sure that's too important. Not sure about the rest, ni? jaws about it.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Yeah I think we should wait on those since Proton Light/Proton Dark aren't normal themes right now due to how they're implemented. When we swap them over these issues should go away.