1695356 - permissions panel icon does not show

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P1)

Description

[Simon Mainey]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

since Bug 1596897 (I guess)

STR

• new profile FF87+
• open https://example.com/
• ctrl-I - change cookies to block

Expected: decoupled permissions icon to show
Actual: no permissions icon

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1695356 - Show permission indicator for any non-default site-permissions. r=johannh!

Before decoupling the permission panel in Bug 1695356, the permission indicator was
not shown if we had a blocked permission icon to show instead. With the decoupled
permissions panel it needs to be shown whenever we have permissions listed in the
panel. The granted permissions icon is now the anchor for the panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc4df8516bd2
Show permission indicator for any non-default site-permissions. r=johannh

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cc4df8516bd2

Comment 4

[Simon Mainey]

confirmed fixed in nightly, can we backport to 87 please?

Comment 5

[Florencia Di Ciocco, NI to vbalducci]

I've verified that this bug is fixed on ff nightly 88.0a1 (2021-03-08).

Regards, Flor

Comment 6

[Paul Zühlcke [:pbz]]

Comment on attachment 9206064 [details]
Bug 1695356 - Show permission indicator for any non-default site-permissions. r=johannh!

Beta/Release Uplift Approval Request

• User impact if declined: The permission panel (and permission-set indicator) won't show if the "cookie" permission is set to "Block". In this case users don't have a visual indicator in the identity section that a custom permission for the site is set and they can't open the permissions panel. This only happens if the cookie permission is the only custom site permission set. Permissions are still correctly displayed in the "Page Info" window.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small code change with test coverage.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9206064 [details]
Bug 1695356 - Show permission indicator for any non-default site-permissions. r=johannh!

approved for 87.0b8

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9278306cfc12

Comment 9

[Florencia Di Ciocco, NI to vbalducci]

Hi, I've verified that this has been fixed on Beta 87.0b8.

Regards, Flor.