1695364 - Remove AbstractBaseScopeData alignment restrictions

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

As stencil continues to redesign ScopeData types, it is simpler to reorder the fields of js::Scope to avoid the gc::Cell header restrictions limiting BaseScopeData.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1695364 - Reorder fields of js::Scope to remove AbstractBaseScopeData alignment requirement. r?arai!

Reorder fields so that AbstractBaseScopeData can be simplified.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/587d8a869c38
Reorder fields of js::Scope to remove AbstractBaseScopeData alignment requirement. r=arai

Comment 3

[Jon Coppeard (:jonco)]

It's like this because having a pointer to a cell of the same kind in the cell header is problematic for compacting GC. See bug 1645710 which led to the current arrangement.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/587d8a869c38

Comment 5

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg.mozilla.org/integration/autoland/rev/416c30fb2f0b848185ed42c72bb70f93d4a2a688

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/416c30fb2f0b

Comment 7

[Ted Campbell [:tcampbell]]

Thanks for feedback. Abandoning this approach.