Only send exceptions to Sentry if Python files have not been changed
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: mhentges, Assigned: mhentges)
References
Details
Attachments
(1 file, 1 obsolete file)
We've got a bunch of noise in Sentry from exceptions thrown from code in development.
We've tried to make it better in 1645423, but if the affected code isn't in the stack trace, we still have false positives coming through.
However, I think having a clear signal with less data is better than a noisy signal with a lot of data. We can entirely eliminate false positive "noise" by only sending Sentry exceptions that happen on a clean checkout. Specifically, don't send if:
- We're not in a VCS checkout. Building from non-VCS is already on the fringe of active support - if a failure happens, report a bug as usual
- We're not on a commit on
central: if there's un-landed code that may have contributed to the exception, don't send us the exception - There's any un-committed files in the working directory: again, un-landed code may have caused the exception.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Talked to glob, we can get similarly clean signal but with more data if we adjust the filter to just ensure that our python scripts are clean compared our current central ancestor. We should allow modified C++/moz.build/etc files.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
If the "mach" file and all "*.py" files are unchanged, then the reported
exception is likely legitimate and can be reproduced on the public tree.
|
|
Assignee | |
Comment 3•3 years ago
|
||
If the "mach" file and all "*.py" files are unchanged, then the reported
exception is likely legitimate and can be reproduced on the public tree.
|
||
Updated•3 years ago
|
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4541867e67d Only submit Sentry events when Mach is unmodified r=sheehan
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•