Closed Bug 1695499 Opened 4 years ago Closed 4 years ago

Perma TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Caret browsing should now be off. - Got true, expected false when Gecko 88 merges to Beta on 2021-03-22

Categories

(Firefox :: Keyboard Navigation, defect)

Product:
Firefox
Component:
Keyboard Navigation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 + verified

People

(Reporter: bogdan_tara, Assigned: masayuki)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1695499 - Make `browser_f7_caret_browsing.js` wait async `F7` key handling for toggling caret browsing r=Gijs!
48 bytes, text/x-phabricator-request
Details | Review

[Tracking Requested - why for this release]:

Central as Beta simulation

How to run such simulations

Failure log

[task 2021-02-28T11:58:30.696Z] 11:58:30     INFO - TEST-START | toolkit/content/tests/browser/browser_f7_caret_browsing.js
[task 2021-02-28T11:58:30.712Z] 11:58:30     INFO - GECKO(6364) | [Child 6678: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f3409b46000 == 2 [pid = 6678] [id = 11]
[task 2021-02-28T11:58:30.714Z] 11:58:30     INFO - GECKO(6364) | [Child 6678: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7f340a12b740) [pid = 6678] [serial = 34] [outer = (nil)]
[task 2021-02-28T11:58:30.717Z] 11:58:30     INFO - GECKO(6364) | [Child 6678: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7f3409b4a000) [pid = 6678] [serial = 35] [outer = 0x7f340a12b740]
[task 2021-02-28T11:58:30.861Z] 11:58:30     INFO - GECKO(6364) | [Child 6678: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x7f340a123000) [pid = 6678] [serial = 36] [outer = 0x7f340a12b740]
[task 2021-02-28T11:58:31.069Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f90ec462400 == 13 [pid = 6364] [id = 15]
[task 2021-02-28T11:58:31.071Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 27 (0x7f914086dac0) [pid = 6364] [serial = 63] [outer = (nil)]
[task 2021-02-28T11:58:31.071Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 28 (0x7f90ec464000) [pid = 6364] [serial = 64] [outer = 0x7f914086dac0]
[task 2021-02-28T11:58:31.086Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(uri) failed: file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1327
[task 2021-02-28T11:58:31.087Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4253
[task 2021-02-28T11:58:31.129Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/checkouts/gecko/layout/base/nsDocumentViewer.cpp:2729
[task 2021-02-28T11:58:31.277Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f90ec464400 == 14 [pid = 6364] [id = 16]
[task 2021-02-28T11:58:31.278Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 29 (0x7f90ffdfe580) [pid = 6364] [serial = 65] [outer = (nil)]
[task 2021-02-28T11:58:31.282Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 30 (0x7f90ec4c2c00) [pid = 6364] [serial = 66] [outer = 0x7f90ffdfe580]
[task 2021-02-28T11:58:31.290Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(uri) failed: file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1327
[task 2021-02-28T11:58:31.290Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4253
[task 2021-02-28T11:58:31.326Z] 11:58:31     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/checkouts/gecko/layout/base/nsDocumentViewer.cpp:2729
[task 2021-02-28T11:58:31.588Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f828ace7400 == 1 [pid = 6529] [id = 19] [url = https://example.com/browser/toolkit/content/tests/browser/file_silentAudioTrack.html]
[task 2021-02-28T11:58:31.589Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7f828ace6800) [pid = 6529] [serial = 47] [outer = (nil)] [url = https://example.com/browser/toolkit/content/tests/browser/file_nonAutoplayAudio.html]
[task 2021-02-28T11:58:31.589Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7f828ace2400) [pid = 6529] [serial = 44] [outer = (nil)] [url = about:blank]
[task 2021-02-28T11:58:31.590Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7f828ace7000) [pid = 6529] [serial = 49] [outer = (nil)] [url = about:blank]
[task 2021-02-28T11:58:31.591Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f828ace3400) [pid = 6529] [serial = 46] [outer = (nil)] [url = about:blank]
[task 2021-02-28T11:58:31.592Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f828ace6c00 == 0 [pid = 6529] [id = 20] [url = about:blank]
[task 2021-02-28T11:58:31.668Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f828acdb580) [pid = 6529] [serial = 53] [outer = (nil)] [url = about:blank]
[task 2021-02-28T11:58:31.668Z] 11:58:31     INFO - GECKO(6364) | [Child 6529: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7f828acdb740) [pid = 6529] [serial = 50] [outer = (nil)] [url = https://example.com/browser/toolkit/content/tests/browser/file_silentAudioTrack.html]
[task 2021-02-28T11:58:32.029Z] 11:58:32     INFO - TEST-INFO | started process screentopng
[task 2021-02-28T11:58:32.250Z] 11:58:32     INFO - TEST-INFO | screentopng: exit 0
[task 2021-02-28T11:58:32.251Z] 11:58:32     INFO - Buffered messages logged at 11:58:30
[task 2021-02-28T11:58:32.252Z] 11:58:32     INFO - Entering test bound checkTogglingCaretBrowsing
[task 2021-02-28T11:58:32.252Z] 11:58:32     INFO - Buffered messages logged at 11:58:31
[task 2021-02-28T11:58:32.253Z] 11:58:32     INFO - Dialog opened.
[task 2021-02-28T11:58:32.253Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | No button should be the default - 
[task 2021-02-28T11:58:32.254Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Checkbox shouldn't be checked by default. - 
[task 2021-02-28T11:58:32.255Z] 11:58:32     INFO - Dialog unloaded
[task 2021-02-28T11:58:32.255Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Caret browsing should still be off after cancelling the dialog. - 
[task 2021-02-28T11:58:32.255Z] 11:58:32     INFO - Dialog opened.
[task 2021-02-28T11:58:32.256Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | No button should be the default - 
[task 2021-02-28T11:58:32.256Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Checkbox shouldn't be checked by default. - 
[task 2021-02-28T11:58:32.257Z] 11:58:32     INFO - Dialog unloaded
[task 2021-02-28T11:58:32.258Z] 11:58:32     INFO - Buffered messages logged at 11:58:32
[task 2021-02-28T11:58:32.258Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Caret browsing should be on after accepting the dialog. - 
[task 2021-02-28T11:58:32.259Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Shouldn't open a dialog to turn caret browsing off. - 
[task 2021-02-28T11:58:32.259Z] 11:58:32     INFO - Buffered messages finished
[task 2021-02-28T11:58:32.259Z] 11:58:32     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Caret browsing should now be off. - Got true, expected false
[task 2021-02-28T11:58:32.260Z] 11:58:32     INFO - Stack trace:
[task 2021-02-28T11:58:32.260Z] 11:58:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1359
[task 2021-02-28T11:58:32.260Z] 11:58:32     INFO - chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_f7_caret_browsing.js:syncToggleCaretNoDialog:83
[task 2021-02-28T11:58:32.261Z] 11:58:32     INFO - chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_f7_caret_browsing.js:checkTogglingCaretBrowsing:149
[task 2021-02-28T11:58:32.261Z] 11:58:32     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f90ec468400 == 15 [pid = 6364] [id = 17]
[task 2021-02-28T11:58:32.261Z] 11:58:32     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 31 (0x7f90ffdfee40) [pid = 6364] [serial = 67] [outer = (nil)]
[task 2021-02-28T11:58:32.263Z] 11:58:32     INFO - GECKO(6364) | [Parent 6364: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 32 (0x7f90ec4c1400) [pid = 6364] [serial = 68] [outer = 0x7f90ffdfee40]
[task 2021-02-28T11:58:32.263Z] 11:58:32     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(uri) failed: file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1327
[task 2021-02-28T11:58:32.264Z] 11:58:32     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4253
[task 2021-02-28T11:58:32.264Z] 11:58:32     INFO - GECKO(6364) | [Parent 6364, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/checkouts/gecko/layout/base/nsDocumentViewer.cpp:2729
[task 2021-02-28T11:58:32.264Z] 11:58:32     INFO - Dialog opened.
[task 2021-02-28T11:58:32.265Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | No button should be the default - 
[task 2021-02-28T11:58:32.266Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Checkbox shouldn't be checked by default. - 
[task 2021-02-28T11:58:32.266Z] 11:58:32     INFO - Dialog unloaded
[task 2021-02-28T11:58:32.314Z] 11:58:32     INFO - TEST-PASS | toolkit/content/tests/browser/browser_f7_caret_browsing.js | Caret browsing should still be off after cancelling the dialog. - 
[task 2021-02-28T11:58:32.335Z] 11:58:32     INFO - GECKO(6364) | [Child 6678, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111 (NS_ERROR_NOT_AVAILABLE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1349
[task 2021-02-28T11:58:32.339Z] 11:58:32     INFO - Leaving test bound checkTogglingCaretBrowsing
...
Flags: needinfo?(masayuki)

Hmm, that's really odd. Indeed, it's my fault, and I should've updated browser_f7_caret_browsing.js waits the test result because my fix makes F7 key handling become async if remote content has focus. However, I don't understand why this failure does not occur in mozilla-central. It should occur...

Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Flags: needinfo?(masayuki)

prompts.windowPromptSubDialog is only true in Nightly (1). See also bug 1685313.

After fixing bug 1520263, F7 key handling in chrome becomes async when
focused element is a remote content. Therefore, the test should wait a
reply event from remote content in the cases.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/3085a7babee2 Make `browser_f7_caret_browsing.js` wait async `F7` key handling for toggling caret browsing r=Gijs

https://hg.mozilla.org/mozilla-central/rev/3085a7babee2

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: