Closed Bug 1695548 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27828 - css-ui: Computed value for 'appearance' should be the specified value

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27828 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27828
Details from upstream follow.

b'Kent Tamura <tkent@chromium.org>' wrote:

css-ui: Computed value for 'appearance' should be the specified value

Some CSS properties such as 'background-color' disable element's
appearance. getComputedStyle() returned 'none' value for the
'appearance' property of such elements though it should return the
specified value according to the standard [1].

This CL fixes it. The new behavior matches to Firefox and Safari TP.

[1] https://drafts.csswg.org/css-ui-4/#propdef-appearance

Bug: 1182587
Change-Id: Ie53275ca0bd0b2e534de0620ee59f9cc215a0d5c
Reviewed-on: https://chromium-review.googlesource.com/2721521
WPT-Export-Revision: 4d8e75f87ceb240da2181e9cd85faaf7dd6db18e

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 342 subtests

Status Summary

Firefox

OK : 1
PASS: 329
FAIL: 13

Chrome

OK : 1
PASS: 308
FAIL: 34

Safari

OK : 1
PASS: 25
FAIL: 317

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-ui/appearance-cssom-001.html
-webkit-appearance: slider-horizontal: FAIL
-moz-appearance (should not be supported): FAIL

New Tests That Don't Pass

/css/css-ui/appearance-cssom-001.html
-webkit-appearance: push-button: FAIL (Chrome: FAIL, Safari: FAIL)
-webkit-appearance: slider-horizontal: FAIL (Chrome: PASS, Safari: PASS)
-webkit-appearance: square-button: FAIL (Chrome: FAIL, Safari: FAIL)
-webkit-appearance: meterbar (invalid): FAIL (Chrome: PASS, Safari: FAIL)
-webkit-appearance: progressbar (invalid): FAIL (Chrome: PASS, Safari: FAIL)
-webkit-appearance: textfield-multiline (invalid): FAIL (Chrome: PASS, Safari: FAIL)
appearance: push-button: FAIL (Chrome: FAIL, Safari: FAIL)
appearance: slider-horizontal: FAIL (Chrome: PASS, Safari: FAIL)
appearance: square-button: FAIL (Chrome: FAIL, Safari: FAIL)
appearance: meterbar (invalid): FAIL (Chrome: PASS, Safari: FAIL)
appearance: progressbar (invalid): FAIL (Chrome: PASS, Safari: FAIL)
appearance: textfield-multiline (invalid): FAIL (Chrome: PASS, Safari: FAIL)
-moz-appearance (should not be supported): FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3778998c68a
[wpt PR 27828] - css-ui: Computed value for 'appearance' should be the specified value, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d3778998c68a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.