1695553 - Implement native-looking scrollbar drawing for Windows 7 with the non-native theme

Status: RESOLVED WONTFIX

(Core :: Widget, task)

Description

[Markus Stange [:mstange]]

With the non-native theme on Windows, we'd like the scrollbars on Windows 7 to still look like Windows 7 scrollbars.
These will look like the Windows 7 default theme scrollbars and not respect custom Windows themes.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1695553 - Move ComputeScrollbarParams from ScrollbarDrawingMac to a new ScrollbarDrawing class, and rename the files. r=emilio

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1695553 - Implement ScrollbarDrawingWin7. r=emilio

This got quite complicated, due to all the highlights and shadows and bevels.

Depends on D106742

Comment 3

[Markus Stange [:mstange]]

Attachment: VirtualBox_IE10 - Win7_25_02_2021_22_27_58.png

I downloaded a Windows 7 VM from the IE testing page at https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ and took some screenshots.

Comment 4

[Markus Stange [:mstange]]

Attachment: VirtualBox_IE10 - Win7_25_02_2021_22_28_45.png

Comment 5

[Markus Stange [:mstange]]

Attachment: VirtualBox_IE10 - Win7_25_02_2021_22_29_11.png

Comment 6

[Markus Stange [:mstange]]

Attachment: VirtualBox_IE10 - Win7_25_02_2021_22_29_25.png

Comment 7

[Markus Stange [:mstange]]

Attachment: VirtualBox_IE10 - Win7_25_02_2021_22_29_33.png

Comment 8

[Markus Stange [:mstange]]

Attachment: testing patch for mac

I used this patch for testing. It draws Win7 scrollbars on macOS.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Taking. Will take a look at what other browsers / apps etc do on windows tomorrow or next week to either take this across the finish line or wontfix (and leave win10-style scrollbars).

So far we've got no complaints, but I could believe win7 is underrepresented in our nightly / beta population.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Even IE11 seems to use win10-looking scrollbars, so does Chrome and Edge, so given the current priorities I think this is ok to wontfix.