Closed Bug 1695568 Opened 3 years ago Closed 3 years ago

Strip https from hover tooltips and use broken lock indicators for http URLs

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: caspy77, Assigned: jfkthame)

References

Details

(Keywords: helpwanted, Whiteboard: [proton-tooltips])

Attachments

(1 file)

The vast majority of sites I visit are https - and I think we have stats that support this for the average user too.

Currently the tooltip on hover in Proton shows the full URL. Somewhat similarly Chrome shows the URL too - well, it just shows the base domain.

We should consider removing the https:// to reduce mental overhead. The Chrome way is easier to glance at and discern more info more quickly.

If the site is not https then, as we do in the URL bar normally, we add the broken lock icon at the front (can we do that in a tooltip?).

Whiteboard: [proton-tabs-bar]
Severity: -- → S3
Component: Theme → Tabbed Browser
Priority: -- → P3
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

Caveat: I don't really know my way around front-end code at all. But I thought I'd take a look at this, so here's a patch that seems to work nicely in my local build.

Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0b9303969bd
Strip https:// from the URL in proton tab tooltips; add a broken-lock icon to http:// URLs. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Whiteboard: [proton-tabs-bar] → [proton-tooltips]

Hello I have managed to reproduce the issue with Fx 88.0a1 (2021-03-01) on Ubuntu. I can confirm that the issue is fixed with Fx 88.0a1 (2021-03-15) on all OS's.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: