1695592 - Moving a Contact from one Carddav Addressbook to another prevents the synchronization

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[cn]

Attachment: TB_Carddav_move.txt

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Subscribe to two Carddav adress books in Beta 87. Drag and Drop one contact from one address book to the other.

Actual results:

The contact is moved on the Thunderbird side but not synced to the new address book on the server. It is deleted in the old address book on both server and Thudnerbird.

Expected results:

The contact should be moved and synced to the server. The problem is that Thunderbird is using the URL (C4849D44-FB00-0001-BB82-1F9E1DA912C5) associated with the "origin" address book not the one of the target address book (902-5FD1CA80-129-5915DC00) (see attached file)

Comment 1

[Geoff Lankow (:darktrojan)]

Thanks for the report, and for figuring out the problem. It should be simple to fix.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1695592 - Don't copy CardDAV-specific properties to another directory. r?mkmelin

The _etag and _href properties only make sense in the context of a card's original directory. Remove them when moving or copying a card to another directory.

Also if we change the card's UID when copying it, make sure the stored vCard has the updated UID too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ccaa9ec02a7
Don't copy CardDAV-specific properties to another directory. r=mkmelin

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9217676 [details]
Bug 1695592 - Don't copy CardDAV-specific properties to another directory. r?mkmelin

[Triage Comment]
Taking for 89.0b4.

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/36299c4ecc04

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1695592-esr78.diff

[Approval Request Comment]
Regression caused by (bug #): Never worked
User impact if declined: Address book gets confused if moving contacts between directories
Testing completed (on c-c, etc.): In 89.0b4
Risk to taking this patch (and alternatives if risky): Small

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9223685 [details] [diff] [review]
1695592-esr78.diff

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.11.0:
https://hg.mozilla.org/releases/comm-esr78/rev/17dc00ace32e