If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

config/nsinstall.c doesn't support dirs ending with forward slash

RESOLVED FIXED in mozilla1.2beta

Status

SeaMonkey
Build Config
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: jhp (no longer active), Assigned: hacker formerly known as seawood@netscape.com)

Tracking

Trunk
mozilla1.2beta
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.94 KB, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
(Reporter)

Description

15 years ago
On OS/2, the stat() function doesn't like it if the pathname ends in a forward
slash (or backslash).  Need to add OS/2 specific code to remove the trailing slash.
(Reporter)

Comment 1

15 years ago
Created attachment 99752 [details] [diff] [review]
patch

Remove trailing slash from "todir" before calling stat().  Also, take the
windows route of using an external nsinstall.exe (our nsinstall.exe is based on
config/nsinstall.c).
Comment on attachment 99752 [details] [diff] [review]
patch

r=cls
Attachment #99752 - Flags: review+
Patch has been checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.2beta

Comment 4

15 years ago
Don't you want:
  todir[strlen(todir)-1] = '\0';
instead of:
  todir[strlen(todir)-1] = '/0';
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.