1695662 - Land some preliminary changes for bug 1689413

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1695662 part 1 - Add js::EnumFlags base class based on ScriptFlagBase. r?tcampbell!

js::EnumFlags will also be used for ObjectFlags later on.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1695662 part 2 - Replace DictionaryShapeLink::prevPtr with prev/setPrev methods. r?tcampbell!

This lets us avoid an ugly reinterpret_cast<GCPtrShape>() when we move JSObject's
shape pointer to the cell header.

Depends on D106775

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55161730da86
part 1 - Add js::EnumFlags base class based on ScriptFlagBase. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/2149fe1086c5
part 2 - Replace DictionaryShapeLink::prevPtr with prev/setPrev methods. r=tcampbell

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/55161730da86
https://hg.mozilla.org/mozilla-central/rev/2149fe1086c5

Comment 5

[Jan de Mooij [:jandem]]

I realized there's more I can split off.

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1695662 part 3 - Remove BaseShape's OWNED_SHAPE flag. r?tcampbell!

The flag is equivalent to checking unowned_ != nullptr so do that instead.

Unowned vs Owned BaseShapes will be removed soon but this simplifies the next patch
because now all flags stored in BaseShape are object flags (see OBJECT_FLAG_MASK).

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1695662 part 4 - Remove NativeObject::hasAllFlags. r?tcampbell!

This is equivalent to JSObject::hasAllFlags now that all objects have a shape again.

Move JSObject::hasAllFlags from JSObject-inl.h to JSObject.h to avoid dependency
issues.

Depends on D106899

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1695662 part 5 - Clean up object flags, use EnumFlags. r?tcampbell!

Changes object flags to an enum class + js::EnumFlags. This improves type safety
and removes references to "base shape flags", so that we can more easily move this
from BaseShape to Shape later on.

Depends on D106900

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ee0f13ba9ef
part 3 - Remove BaseShape's OWNED_SHAPE flag. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/401217a0f9dd
part 4 - Remove NativeObject::hasAllFlags. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/76119db68744
part 5 - Clean up object flags, use EnumFlags. r=tcampbell

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4ee0f13ba9ef
https://hg.mozilla.org/mozilla-central/rev/401217a0f9dd
https://hg.mozilla.org/mozilla-central/rev/76119db68744