1695674 - Skeleton UI needs updating to Proton tab style

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

During startup the Skeleton UI shows the Photon tab shape. This will need to be updated to show the Proton (disconnected) tab shape before we ship Proton in Firefox 89.

Doug, is this something you can look in to?

Comment 1

[Doug Thayer [:dthayer] (he/him)]

Yup! It's already in our plans - just didn't have a bug yet. So thank you! Do you think the Proton designs are stable enough now to develop against?

Comment 2

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Yes, they are stable enough now to develop against. Thanks!

Comment 3

[Doug Thayer [:dthayer] (he/him)]

Attachment: Bug 1695674 - Update Skeleton UI layout+colors to match Proton r?emalysz

Comment 4

[Doug Thayer [:dthayer] (he/him)]

Attachment: Bug 1695674 - Ensure we use RGB macro for FillRect r?emalysz

We specify our colors like 0xrrggbb, but CreateSolidBrush expects a
color created with the RGB macro, which actually arranges it as
0xbbggrr. This change has us use the RGB macro to give a color when
creating the brush.

Depends on D107944

Comment 5

[Doug Thayer [:dthayer] (he/him)]

Attachment: Bug 1695674 - Change Skeleton UI colors to match Proton r?emalysz

This causes them to match the figma mocks, not the currently implemented
colors.

Depends on D107945

Comment 6

[Romain Testard [:RT]]

We discussed at our MR1 product experience review that we should handle skeleton UI / MR1 interdependencies as follows:

• Skeleton UI availability should not block shipping MR1
• Skeleton UI should not ship until this bug is resolved

Comment 7

[Romain Testard [:RT]]

Can I please have a status update here? Per Comment 6 Skeleton UI won't block MR1 but should not make it to Beta if this bug is not resolved.

Comment 8

[Doug Thayer [:dthayer] (he/him)]

Waiting on review from emalysz. Throwing the needinfo her way, though I know she's looking at it as we talked about it yesterday. I don't have any worries about this landing very shortly.

Comment 9

[Emma Malysz]

We'll make sure to land this patch later today before soft freeze

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f69c907eba1
Update Skeleton UI layout+colors to match Proton r=emalysz
https://hg.mozilla.org/integration/autoland/rev/5632c59062ad
Ensure we use RGB macro for FillRect r=emalysz

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0f69c907eba1
https://hg.mozilla.org/mozilla-central/rev/5632c59062ad