Closed Bug 1695736 Opened 3 months ago Closed 2 months ago

Handle GetElem with undefined/null in CacheIR

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

On reddit the biggest missing CacheIR stub is handling for looking up undefined with GetElem. I assume this is usually a bug, but we might as well support it...

Might as well add some nicer APIs to make the following patch nicer to read.

Attachment #9206160 - Attachment description: Bug 1695736 - Handle GetElem with undefined/null in CacheIR. r?jandem → Bug 1695736 - Handle GetElem/SetElem/Has with undefined/null in CacheIR. r?jandem
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6f29f36ea34c
Atom API for PropertyKey. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0963e86271f7
Handle GetElem/SetElem/Has with undefined/null in CacheIR. r=jandem
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.