1695792 - New copy for Firefox accounts menu error notifications

Status: RESOLVED FIXED

(Firefox :: Menus, task, P3)

Description

[Molly Howell (she/her) (no longer active)]

The notification strings that appear in the app menu when problems are detected with a Firefox account are defined here. Yes, they need to be migrated to Fluent, but not in this bug.

The same strings (as in, those same entries in the properties file) are used for both app menu notifications and also for the FxA toolbar item menu; this should not be changed.

The new strings to replace those with are:

• account.finishAccountSetup: "Finish account setup" (note the sentence casing)
• account.reconnectToFxA: "Account disconnected", but still pending final approval as of this writing, check Figma

This doesn't need to be behind any Proton prefs or blocked on any other Proton landing scheduling, because these changes work just as well on their own.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Molly Howell (she/her) [:mhowell] from comment #0)

Yes, they need to be migrated to Fluent, but not in this bug.

Out of curiosity, why not? I'm not familiar with the code, but it just seems a matter of replacing this.fxaStrings.GetStringFromName with this.fluentStrings.formatValueSync() , and there's no migration involved since strings are changing.

I understand the goal is to land these quickly, but if the amount of work requested is the same, we should add the new strings directly to Fluent.

Comment 2

[Molly Howell (she/her) (no longer active)]

Well yes, I was trying to keep the work as minimal as possible, and I'm not really familiar with the code either so I'd rather keep the changes as small as possible. But if it really is that easy, then you're right, there's no reason not to.

Comment 3

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1695792 - Update copy for accounts error notifications. r=mconley,#fluent-reviewers

Also take the opportunity to convert these two strings to Fluent,
since we're changing the text here anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1f7bf0f85fd
Update copy for accounts error notifications. r=mconley,fluent-reviewers

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b1f7bf0f85fd