Closed
Bug 1695864
Opened 4 years ago
Closed 4 years ago
nsWebBrowserPersist::SerializeNextFile iterates mURIMap twice
Categories
(Core :: DOM: Core & HTML, task, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(1 file)
nsWebBrowserPersist::SerializeNextFile iterates mURIMap twice:
- First, just to check whether the second iteration would have any matches that need persisting
- Second, to persist those matches
The first iteration seems useless and should be removed.
There's a comment in place that mentions that the number of not-yet-persisted URIs could be maintained separately, which is still an optimization that can be implemented after fixing this.
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D106883
|
||
Updated•4 years ago
|
Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P3
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97ab44ec70e2
Remove redundant mURIMap iteration in nsWebBrowserPersist::SerializeNextFile. r=jld
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•