169589 - [mac] ctrl-tab no longer moves btwn frames

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[sairuh (rarely reading bugmail)]

looks like a regression from bug 136915, where ctrl-tab was implemented to move
btwn tabbed browsers. tested using 2002.09.18.08 comm trunk builds on mac os x 10.2.

after chatting with aaronl, ctrl-tab no longer cycles btwn the frames in a
framed document on *only* win32 and linux. [shift]-F6 now has that function.
however, on mac the ctrl-tab behavior should still be preserved.

1. go to a page with frames, eg, http://faqs.org/
2. hit ctrl-tab to cycle btwn the frames.

results: nothing happens (no navigation). note that if you have multiple tabbed
browsers open, and one of them has frames, ctrl-tab would switch btwn tabs --ie,
still not cycle through the frames of the framed document.

expected: on mac, ctrl-tab should cycle through frames, not tabs.

workaround: [shift]-F6 still works on mac --unless you've already programmed the
function keys.

Comment 1

[Aaron Leventhal]

Brade, what do you think about this one? Should we 

1) just not have a keyboard shortcut for frame navigation on mac, and make
people use tab to cycle through everything? 
2) use Ctrl+[shift]+tab as we did before, saving only the unpopular
Ctrl+PgUp/PgDn for tab navigation
3) Come up with a new set of keys for frame navigation

Comment 2

[[e-mail]]

1. [Always off on Mac]
<constructor>
  if (/Mac/.test(navigator.platform))
    this.mTabBox.setAttribute("handleCtrlTab", "false");
</constructor>
2. [Set pref defaults by platform]
<constructor>
  this.mTabBox.setAttribute("handleCtrlTab",
this.mPrefs.getBoolPref("browser.tabs.handleCtrlTab"));
</constructor>

Comment 3

[[e-mail]]

setAttribute? /me slaps wrist - I should of course set the property:
  this.mTabBox.handleCtrlTab = !/Mac/.test(navigator.platform);
or
  this.mTabBox.handleCtrlTab =
this.mPrefs.getBoolPref("browser.tabs.handleCtrlTab");

Comment 4

[Kathleen :Brade]

Aaron--at this stage I'd say let's try to be as compatible with previous Mac
versions of mozilla as possible (moz1.0, 1.1, etc)  I prefer option 2 or 3 over
option 1.

Comment 5

[[e-mail]]

Attachment: Disable tabbrowser ctrl+tab on Mac platforms

Comment 6

[Kyle Yuan]

*** Bug 154915 has been marked as a duplicate of this bug. ***

Comment 7

[Kathleen :Brade]

fix checked in for Neil

Comment 8

[sairuh (rarely reading bugmail)]

neil, thanks a lot for fixing this.

vrfy'd fixed with recent trunk builds:

2002.12.10.07 mach-o mozilla (OS X 10.2.2): Control-Tab now cycles through the
frames and urlbar ([shift]-F6 still works to accomplish the same thing).
Control-PageUp/Down still cycles btwn browser tabs.

2002.12.10.08 comm win2k: both Control-Tab and Control-PageUp/Down cycle btwn
browser tabs. [shift]-F6 cycles through frames and the urlbar.

2002.12.09.08 comm linux rh8: same as win2k.

Comment 9

[Jesse Ruderman]

This change (or a similar one for Firefox) was reversed for Firefox in bug 264787 comment 32.