1695896 - Add log and Edit log on breakpoint in sidebar should scroll line into view

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This has been originally reported here: https://github.com/firefox-devtools/debugger/issues/8198

STR:

1. Load http://janodvarko.cz/firebug/tests/601/Issue601.htm
2. Open DevTools and select the Debugger panel
3. Open file Issue601.htm and create regular BP on line 64
4. Scroll the source so the BP is not visible
5. In the Breakpoints side panel right click on the BP and pick "Add Log" (or "Edit Log")

AR: the BP and log editor are not visible
ER: the source scrolls so the BP and log editor are visible.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

A patch attached to the original issue. It seems to be working, but might need to be revisit.

diff --git a/devtools/client/debugger/src/components/SecondaryPanes/Breakpoints/BreakpointsContextMenu.js b/devtools/client/debu--- a/devtools/client/debugger/src/components/SecondaryPanes/Breakpoints/BreakpointsContextMenu.js
+++ b/devtools/client/debugger/src/components/SecondaryPanes/Breakpoints/BreakpointsContextMenu.js
@@ -233,26 +233,32 @@ export default function showContextMenu(
     ),
   };

   const addLogPointItem = {
     id: "node-menu-add-log-point",
     label: L10N.getStr("editor.addLogPoint"),
     accesskey: L10N.getStr("editor.addLogPoint.accesskey"),
     disabled: false,
-    click: () => openConditionalPanel(selectedLocation, true),
+    click: () => {
+      selectSpecificLocation(cx, selectedLocation);
+      openConditionalPanel(selectedLocation, true);
+    },
     accelerator: formatKeyShortcut(L10N.getStr("toggleCondPanel.logPoint.key")),
   };

   const editLogPointItem = {
     id: "node-menu-edit-log-point",
     label: L10N.getStr("editor.editLogPoint"),
     accesskey: L10N.getStr("editor.editLogPoint.accesskey"),
     disabled: false,
-    click: () => openConditionalPanel(selectedLocation, true),
+    click: () => {
+      selectSpecificLocation(cx, selectedLocation);
+      openConditionalPanel(selectedLocation, true);
+    },
     accelerator: formatKeyShortcut(L10N.getStr("toggleCondPanel.logPoint.key")),
   };

   const removeLogPointItem = {
     id: "node-menu-remove-log",
     label: L10N.getStr("editor.removeLogPoint.label"),
     accesskey: L10N.getStr("editor.removeLogPoint.accesskey"),
     disabled: false,

Comment 2

[Hubert Boma Manilla (:bomsy)]

This might be a good first or mentored bug

Comment 3

[Surya Balakrishnan [:surya_b]]

Hi, I'd like to work on this. Can it be assigned to me?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you, thank you for helping.

Honza

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 6

[Leslie]

Hi there, I'd like to work on this bug. Can it be assigned to me?

Comment 7

[Hubert Boma Manilla (:bomsy)]

Hi Leslie,
Sure I've assigned it to you.

Feel free to ask any questions.

Comment 8

[Leslie]

Attachment: Bug 1695896 Add log, edit log on breakpoint in sidebar scroll line into view. r?bomsy

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The patch looks good, just an automated test (mochitest) is missing
Still feels like a good first bug

Comment 11

[Luke Swiderski]

Attachment: Bug 1695896 - Add/edit log on breakpoint in sidebar scroll line into view. r=bomsy

This patch scrolls the editor to the log input when adding or editing a log
from the breakpoint context menu.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a57484614314
Add/edit log on breakpoint in sidebar scroll line into view. r=bomsy

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a57484614314