1695924 - test_trr_httpssvc.js fails when run in conjunction with test_odoh.js

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

This fails locally for me:
mach test --verbose netwerk/test/unit/test_odoh.js netwerk/test/unit/test_trr_httpssvc.js

The first lookup in the httpssvc test [1] fails with NS_ERROR_UNKNOWN_HOST (2152398878).

I'm not sure why this isn't failing in automation... maybe a different test order.

[1] https://searchfox.org/mozilla-central/rev/3f97afc8db535f9b0232222cb48cc4cbf8334c76/netwerk/test/unit/test_trr_httpssvc.js#130

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Marking P2 because I'm worried that this is a manifestation of some underlying problem that's being masked in some configurations/environments but not others.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

 0:09.22 INFO   throw new ERR_OUT_OF_RANGE(type || 'offset',
 0:09.22 INFO   ^
 0:09.22 INFO 
 0:09.22 INFO RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 290. Received 291
 0:09.22 INFO     at boundsError (internal/buffer.js:82:9)
 0:09.22 INFO     at writeU_Int8 (internal/buffer.js:737:5)
 0:09.22 INFO     at Buffer.writeUInt8 (internal/buffer.js:744:10)
 0:09.22 INFO     at Object.svcparam.encode (/home/icecold/mozilla-central/testing/xpcshell/dns-packet/index.js:1432:15)
 0:09.22 INFO     at Object.rhttpssvc.encode (/home/icecold/mozilla-central/testing/xpcshell/dns-packet/index.js:1532:14)
 0:09.22 INFO     at Object.answer.encode (/home/icecold/mozilla-central/testing/xpcshell/dns-packet/index.js:1635:9)
 0:09.22 INFO     at encodeList (/home/icecold/mozilla-central/testing/xpcshell/dns-packet/index.js:1828:9)
 0:09.22 INFO     at Object.exports.encode (/home/icecold/mozilla-central/testing/xpcshell/dns-packet/index.js:1758:12)
 0:09.22 INFO     at IncomingRequest.finishedData (/home/icecold/mozilla-central/testing/xpcshell/moz-http2/moz-http2.js:975:27)
 0:09.22 INFO     at IncomingRequest.emit (events.js:314:20) {
 0:09.22 INFO   code: 'ERR_OUT_OF_RANGE'
 0:09.22 INFO }

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1695924 - Clear svcparam.odoh after using it, r=#necko

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a46e947e1c
Clear svcparam.odoh after using it, r=necko-reviewers,dragana

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d7a46e947e1c