1695963 - Rename "Default" theme to "System" or a similar name

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

UX would like to change the name of the default theme in Firefox from "Default". Something like “System”, “System Default”, “OS Theme” are more commonly used naming patterns for this setting. “Auto” on macOS means the theme changes from light to dark based on the time of day.

Comment 1

[Tim Nguyen :ntim]

Hi Betsy, would it be possible to get the final name for this? Thanks!

Comment 2

[Betsy Mikel [:betsymi]]

The UX team is reviewing this issue now and will have a final decision soon. To clarify, this name would appear in the about:addons theme picker, correct? We also know it's on onboarding, and will align the terminology there.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Yes, the name will appear in about:addons theme pickers, Customize mode theme picker, and onboarding.

Comment 4

[Meridel [:meridel]]

Onboarding treatment is TBD. Depending on onboarding design, we may not explicitly surface it at all. I am supporting that work and will update copy as needed.

Jared, can you please see my question in this doc? https://docs.google.com/document/d/1tjSEJt4RiqwdS6FKpcC_dvHGcdSOLP1nx4DYwhJ7Ed8/edit#

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Answered in the doc

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1695963 - Rename 'Default' theme to 'System setting'.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86f0423265b7
Rename 'Default' theme to 'System setting'. r=flod,mixedpuppy

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_ext_management_themes.js

backout: https://hg.mozilla.org/integration/autoland/rev/6108b53cc4da3f856084d4a4bdc457fffd53ebed

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=dr5NWsYYRp6O-4oQXerwVA.0&duplicate_jobs=visible&revision=86f0423265b7539d7a4d4ee636e123ab7ae576fd&searchStr=browser-chrome&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=336369745&repo=autoland&lineNumber=16525

[task 2021-04-13T15:12:09.985Z] 15:12:09 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | addon is theme - Expected: theme, Actual: theme -
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - Buffered messages finished
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | default disabled - Got "System setting", expected "Default"
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - Stack trace:
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - chrome://mochikit/content/browser-test.js:test_is:1362
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_management_themes.js:test_management_themes:128
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | got expected addons - Expected: 5, Actual: 5 -

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58eee3570cee
Rename 'Default' theme to 'System setting'. r=flod,mixedpuppy

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/58eee3570cee