Closed Bug 1695963 Opened 8 months ago Closed 6 months ago

Rename "Default" theme to "System" or a similar name

Categories

(Firefox :: Theme, enhancement, P2)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-foundations] [priority:2c])

Attachments

(1 file)

UX would like to change the name of the default theme in Firefox from "Default". Something like “System”, “System Default”, “OS Theme” are more commonly used naming patterns for this setting. “Auto” on macOS means the theme changes from light to dark based on the time of day.

Points: --- → 1

Hi Betsy, would it be possible to get the final name for this? Thanks!

Flags: needinfo?(bmikel)

The UX team is reviewing this issue now and will have a final decision soon. To clarify, this name would appear in the about:addons theme picker, correct? We also know it's on onboarding, and will align the terminology there.

Flags: needinfo?(bmikel) → needinfo?(mwalkington)

Yes, the name will appear in about:addons theme pickers, Customize mode theme picker, and onboarding.

Onboarding treatment is TBD. Depending on onboarding design, we may not explicitly surface it at all. I am supporting that work and will update copy as needed.

Jared, can you please see my question in this doc? https://docs.google.com/document/d/1tjSEJt4RiqwdS6FKpcC_dvHGcdSOLP1nx4DYwhJ7Ed8/edit#

Flags: needinfo?(mwalkington) → needinfo?(jaws)

Answered in the doc

Flags: needinfo?(jaws)
Priority: P3 → P2
Whiteboard: [proton-foundations] → [proton-foundations] [priority:2c]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86f0423265b7
Rename 'Default' theme to 'System setting'. r=flod,mixedpuppy

Backed out for failures on browser_ext_management_themes.js

backout: https://hg.mozilla.org/integration/autoland/rev/6108b53cc4da3f856084d4a4bdc457fffd53ebed

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=dr5NWsYYRp6O-4oQXerwVA.0&duplicate_jobs=visible&revision=86f0423265b7539d7a4d4ee636e123ab7ae576fd&searchStr=browser-chrome&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=336369745&repo=autoland&lineNumber=16525

[task 2021-04-13T15:12:09.985Z] 15:12:09 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | addon is theme - Expected: theme, Actual: theme -
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - Buffered messages finished
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | default disabled - Got "System setting", expected "Default"
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - Stack trace:
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - chrome://mochikit/content/browser-test.js:test_is:1362
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_management_themes.js:test_management_themes:128
[task 2021-04-13T15:12:09.986Z] 15:12:09 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | got expected addons - Expected: 5, Actual: 5 -

Flags: needinfo?(jaws)
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58eee3570cee
Rename 'Default' theme to 'System setting'. r=flod,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.