1695982 - Remove print.printer_Mozilla_Save_to_PDF.print_to_filename from about:support

Status: RESOLVED FIXED

(Toolkit :: Printing, task)

Description

[Andrew McCreight [:mccr8]]

I saw a user posting about:support in a bug, and the output included the preference print.printer_Mozilla_Save_to_PDF.print_to_filename, which was the name of a local file on their computer. It seems like this could potentially include private information a user might not want to include.

Comment 1

[Andrew McCreight [:mccr8]]

It looks like the test toolkit/modules/tests/browser/browser_Troubleshoot.js checks for the presence of a pref print.print_to_filename, but not print.printer_Mozilla_Save_to_PDF.print_to_filename.

Comment 2

[Tom S. (please needinfo tschuster)]

I just noticed this in another bug. Seems like emilio removed print_to_filename from the blocklist here: https://hg.mozilla.org/integration/autoland/rev/54ee4e15b971#l5.30

Comment 3

[Tom S. (please needinfo tschuster)]

Seems like we don't do a good job of removing user paths from the about:support copied text anyway.
For example "Startup Cache" > "Disk Cache Path", and various MOZ_CRASHREPORTER_*_DIRECTORY env variables.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

So I removed that from the blacklist because with my initial patch we didn't use that codepath for print prefs at all I think.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1695982 - Don't show print_to_filename prefs in about:support. r=Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a05e8918c4da
Don't show print_to_filename prefs in about:support. r=Gijs

Comment 7

[Andrew McCreight [:mccr8]]

Thanks, Emilio!

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a05e8918c4da

Comment 9

[Andrew McCreight [:mccr8]]

It would be nice if we could backport this, as it is a bit of a privacy issue and it looks to me like it is low risk.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Emilio, ping RE: comment 9.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9211502 [details]
Bug 1695982 - Don't show print_to_filename prefs in about:support. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Potential sensitive information in about:support.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Extremely simple patch
• String changes made/needed: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211502 [details]
Bug 1695982 - Don't show print_to_filename prefs in about:support. r=Gijs

Approved for 88.0b5.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c19bf306e48a

Comment 14

[Daniel Veditz [:dveditz]]

(In reply to Tom Schuster [:evilpie] from comment #3)

Seems like we don't do a good job of removing user paths from the about:support copied text anyway.

The path isn't the main problem here. The filename itself can often have sensitive information. User names, email addresses, "<competitor> merger proposal", "How to file for divorce", etc. Why do we even save this value?