1696075 - Fix sampling feedback detection handling

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

I wrote a new test to capture the fixes we made in bug 1692617:
https://github.com/KhronosGroup/WebGL/pull/3221

With the full battery of tests, there are still cases that we don't get quite right,
so let's fix 'em! :)

Comment 1

[Kelsey Gilbert [:jgilbert]]

FWIW I did double-check that the testcase from bug 1692617 passes, so hopefully my CTS test captures that.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1696075 - Match spec for webgl sampling feedback detection.

I lean really hard into using the precise variable names and language
from the spec here. Previously I had more qualitative/descriptive names,
but I found this to mostly cause confusion. When we're up to our waists
in spec edge cases like we are here, descriptive qualitative names can
just be deceptive, and lead to incorrect intuitions.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f83ddee1a8cf
Match spec for webgl sampling feedback detection. r=lsalzman

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f83ddee1a8cf