1696108 - Headers "learn more" links aren't properly aligned with text

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Headers panel - misaligned icons

It feels like the icons aren't properly aligned with the text they're next to (see attached screenshot)

Comment 1

[Kaushal]

Hello. I would like to work on this issue. Where should I start??

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

1. The "?" icons is rendered using MDNLink component
   https://searchfox.org/mozilla-central/rev/526a5089c61db85d4d43eb0e46edaf1f632e853a/devtools/client/shared/components/MdnLink.js#18-24

2. The MDNLink component is used here in the Headers (side) panel
   https://searchfox.org/mozilla-central/rev/526a5089c61db85d4d43eb0e46edaf1f632e853a/devtools/client/netmonitor/src/components/request-details/HeadersPanel.js#456

3. The MDNLink is shared component, so changes in it might break other places. So, I would rather focus on changing CSS that applies only on the Headers in the Headers (side) panel.

Honza

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 4

[Nathaniel K. Blanquel]

Is anyone still working on this? If not I'd like to take a crack at it.

Comment 5

[Hubert Boma Manilla (:bomsy)]

Go ahead! Assigned to you

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 7

[Kiran G]

Hello, I believe that I have found a solution to this issue. This may be my first contribution, so I was wondering who I should ask to review the patch?

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Hello Kiran,

I can review the patch (nchevobbe) :)

Comment 9

[Kiran G]

Attachment: Bug 1696108 - Adjusted position of learn-more-link buttons and header text r=nchevobbe

Comment 10

[Kiran G]

I was just wondering if you saw that I have uploaded the patch to Phabricator for review.
Thank you,
Kiran

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f9ba2f28613
Adjusted position of learn-more-link buttons and header text r=nchevobbe

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4f9ba2f28613