1696126 - If the up arrow button from Find Toolbar is clicked the Enter key moves selection to the previous match instead of the next

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user opens the Find Toolbar and searches for a term and taps enter, the next matching term on the page will be highlighted. If then, he clicks the up arrow from the right of the toolbar's input box, the previous matching term on the page will be highlighted. Furthermore, if NOW, he taps the Enter key, the previous match will be highlighted instead of the next.

Affected versions

• All

Affected platforms

• All

Steps to reproduce

1. Load a page: https://en.wikipedia.org/wiki/Main_Page
2. CTRL+F
3. Input a common search term: the
   Observe: The first match on the page is selected ("1 of x matches")
4. Tap Enter key
   Observe: The next (second) match is selected ("2 of x matches")
5. Click the up arrow key
   Observe: The previous match is selected ("1 of x matches")
6. Tap the Enter key, again

Expected result

• The next match on the page is selected
  ("2 of x matches")

Actual result

• The previous match on the page is selected
  ("x of x matches Reached top of page, continued from bottom")
• Notice that both the Enter key and SHIFT + ENTER hotkey do the same action now.

Regression range

• This is not a regression

Additional notes

• What happens is that when the user clicks the up arrow button from the Find Toolbar, the focus leaves the input box and remains on the up arrow button, so then if he taps Enter, the up arrow button is pushed (without an animation).
• I assume that the up arrow (and down arrow) button should only be actionable with the SPACE key, like with the other toolbar buttons. (If the SPACE key is tapped in step 6, the up arrow key shows a button press animation.)